[ptxdist] [PATCH] avahi: use working defaults for user/group

[ptxdist] [PATCH] avahi: use working defaults for user/group

[Roland Hieber]

As stated by the (slightly outdated) comments, no user or group named
"avahi" or "avahi-autoipd" exists in the default /etc/passwd or
/etc/group in PTXdist, so Avahi will complain about the missing
user/group and refuse to start with the default configuration. Set the
default values to the unprivileged "nobody"/"nogroup" instead, which
already exist, and remove the outdated comments.

Signed-off-by: Roland Hieber <rhi@pengutronix.de>
---
 rules/avahi.in | 20 ++++----------------
 1 file changed, 4 insertions(+), 16 deletions(-)

diff --git a/rules/avahi.in b/rules/avahi.in
index a038a1efeb2a..90ef7088110b 100644
--- a/rules/avahi.in
+++ b/rules/avahi.in
@@ -74,22 +74,16 @@ if AVAHI_DAEMON
 config AVAHI_USER
 	string
 	prompt "user for running the avahi (mDNS/DNS-SD) daemon"
-	default "avahi"
+	default "nobody"
 	help
 	  Enter the user name to run the avahi (mDNS/DNS-SD) daemon with.
-	  The PTXdist standard configuration has only root, so if you want
-	  to use the avahi default user "avahi" you have to create
-	  a related user yourself.
 
 config AVAHI_GROUP
 	string
 	prompt "group for running the avahi (mDNS/DNS-SD) daemon"
-	default "avahi"
+	default "nogroup"
 	help
 	  Enter the group name to run the avahi (mDNS/DNS-SD) daemon with.
-	  The PTXdist standard configuration has only root, so if you want
-	  to use the avahi default group "avahi" you have to create
-	  a related group yourself.
 
 config AVAHI_SERVICES
 	bool
@@ -130,22 +124,16 @@ if AVAHI_AUTOIP
 config AVAHI_AUTOIP_USER
 	string
 	prompt "user for running the avahi autoip (IPv4LL) daemon"
-	default "avahi-autoipd"
+	default "nobody"
 	help
 	  Enter the user name to run the avahi autoip (IPv4LL) daemon with.
-	  The PTXdist standard configuration has only root, so if you want
-	  to use the avahi default user "avahi-autoipd" you have to create
-	  a related user yourself.
 
 config AVAHI_AUTOIP_GROUP
 	string
 	prompt "group for running the avahi autoip (IPv4LL) daemon"
-	default "avahi-autoipd"
+	default "nogroup"
 	help
 	  Enter the group name to run the avahi autoip (IPv4LL) daemon with.
-	  The PTXdist standard configuration has only root, so if you want
-	  to use the avahi default group "avahi-autoipd" you have to create
-	  a related group yourself.
 endif
 
 config AVAHI_COMPAT
-- 
2.39.5

Re: [ptxdist] [PATCH] avahi: use working defaults for user/group

[Michael Olbrich]

On Mon, Nov 11, 2024 at 12:01:22AM +0100, Roland Hieber wrote:
> As stated by the (slightly outdated) comments, no user or group named
> "avahi" or "avahi-autoipd" exists in the default /etc/passwd or
> /etc/group in PTXdist, so Avahi will complain about the missing
> user/group and refuse to start with the default configuration. Set the
> default values to the unprivileged "nobody"/"nogroup" instead, which
> already exist, and remove the outdated comments.

Nack. These services have separate users for a reason.

I understand that adding users is currently awkward. I've been thinking
about better ways to do this for some time. I'm open for ideas about that.

Regards,
Michael

> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> ---
>  rules/avahi.in | 20 ++++----------------
>  1 file changed, 4 insertions(+), 16 deletions(-)
> 
> diff --git a/rules/avahi.in b/rules/avahi.in
> index a038a1efeb2a..90ef7088110b 100644
> --- a/rules/avahi.in
> +++ b/rules/avahi.in
> @@ -74,22 +74,16 @@ if AVAHI_DAEMON
>  config AVAHI_USER
>  	string
>  	prompt "user for running the avahi (mDNS/DNS-SD) daemon"
> -	default "avahi"
> +	default "nobody"
>  	help
>  	  Enter the user name to run the avahi (mDNS/DNS-SD) daemon with.
> -	  The PTXdist standard configuration has only root, so if you want
> -	  to use the avahi default user "avahi" you have to create
> -	  a related user yourself.
>  
>  config AVAHI_GROUP
>  	string
>  	prompt "group for running the avahi (mDNS/DNS-SD) daemon"
> -	default "avahi"
> +	default "nogroup"
>  	help
>  	  Enter the group name to run the avahi (mDNS/DNS-SD) daemon with.
> -	  The PTXdist standard configuration has only root, so if you want
> -	  to use the avahi default group "avahi" you have to create
> -	  a related group yourself.
>  
>  config AVAHI_SERVICES
>  	bool
> @@ -130,22 +124,16 @@ if AVAHI_AUTOIP
>  config AVAHI_AUTOIP_USER
>  	string
>  	prompt "user for running the avahi autoip (IPv4LL) daemon"
> -	default "avahi-autoipd"
> +	default "nobody"
>  	help
>  	  Enter the user name to run the avahi autoip (IPv4LL) daemon with.
> -	  The PTXdist standard configuration has only root, so if you want
> -	  to use the avahi default user "avahi-autoipd" you have to create
> -	  a related user yourself.
>  
>  config AVAHI_AUTOIP_GROUP
>  	string
>  	prompt "group for running the avahi autoip (IPv4LL) daemon"
> -	default "avahi-autoipd"
> +	default "nogroup"
>  	help
>  	  Enter the group name to run the avahi autoip (IPv4LL) daemon with.
> -	  The PTXdist standard configuration has only root, so if you want
> -	  to use the avahi default group "avahi-autoipd" you have to create
> -	  a related group yourself.
>  endif
>  
>  config AVAHI_COMPAT
> -- 
> 2.39.5
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Re: [ptxdist] [PATCH] avahi: use working defaults for user/group

[Roland Hieber]

On Fri, Nov 29, 2024 at 09:35:38AM +0100, Michael Olbrich wrote:
> On Mon, Nov 11, 2024 at 12:01:22AM +0100, Roland Hieber wrote:
> > As stated by the (slightly outdated) comments, no user or group named
> > "avahi" or "avahi-autoipd" exists in the default /etc/passwd or
> > /etc/group in PTXdist, so Avahi will complain about the missing
> > user/group and refuse to start with the default configuration. Set the
> > default values to the unprivileged "nobody"/"nogroup" instead, which
> > already exist, and remove the outdated comments.
> 
> Nack. These services have separate users for a reason.
> 
> I understand that adding users is currently awkward. I've been thinking
> about better ways to do this for some time. I'm open for ideas about that.

Hmh yes, something like an install_* macro that is called in the targetinstall
stage, and writes the to-be-created users into a file from where the rootfs
package will pick it up later?

 - Roland

-- 
Roland Hieber, Pengutronix e.K.          | rhi@pengutronix.de          |
Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |

Re: [ptxdist] [PATCH] avahi: use working defaults for user/group

[Bruno Thomsen]

Den tors. 13. feb. 2025 kl. 14.40 skrev Roland Hieber <rhi@pengutronix.de>:
>
> On Fri, Nov 29, 2024 at 09:35:38AM +0100, Michael Olbrich wrote:
> > On Mon, Nov 11, 2024 at 12:01:22AM +0100, Roland Hieber wrote:
> > > As stated by the (slightly outdated) comments, no user or group named
> > > "avahi" or "avahi-autoipd" exists in the default /etc/passwd or
> > > /etc/group in PTXdist, so Avahi will complain about the missing
> > > user/group and refuse to start with the default configuration. Set the
> > > default values to the unprivileged "nobody"/"nogroup" instead, which
> > > already exist, and remove the outdated comments.
> >
> > Nack. These services have separate users for a reason.
> >
> > I understand that adding users is currently awkward. I've been thinking
> > about better ways to do this for some time. I'm open for ideas about that.

I know Fedora is looking at solving this issue [1] with systemd sysusers.d [2]
but that is ofcourse not possible in non-systemd builds.

/Bruno

[1] https://fedoraproject.org/wiki/Changes/RPMSuportForSystemdSysusers
[2] https://www.freedesktop.org/software/systemd/man/latest/sysusers.d.html

> Hmh yes, something like an install_* macro that is called in the targetinstall
> stage, and writes the to-be-created users into a file from where the rootfs
> package will pick it up later?
>
>  - Roland
>
> --
> Roland Hieber, Pengutronix e.K.          | rhi@pengutronix.de          |
> Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
> 31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |
>