From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 27 Jan 2025 09:35:58 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tcKb7-0052GN-38 for lore@lore.pengutronix.de; Mon, 27 Jan 2025 09:35:58 +0100 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1tcKb8-0007XT-8F; Mon, 27 Jan 2025 09:35:58 +0100 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tcKaS-0005ju-Oi; Mon, 27 Jan 2025 09:35:16 +0100 Received: from dude05.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::54]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tcKaS-0025un-1o; Mon, 27 Jan 2025 09:35:16 +0100 Received: from mol by dude05.red.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1tcKaS-001WVs-1g; Mon, 27 Jan 2025 09:35:16 +0100 From: Michael Olbrich To: ptxdist@pengutronix.de Date: Mon, 27 Jan 2025 09:35:16 +0100 Message-Id: <20250127083516.363301-1-m.olbrich@pengutronix.de> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250123205453.2841392-1-a.fatoum@pengutronix.de> References: <20250123205453.2841392-1-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [ptxdist] [APPLIED] util-linux: add option for building blkdiscard X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: Ahmad Fatoum Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false Thanks, applied as 9e0602b0e355efaf23b6306c813aa54630d101da. Michael [sent from post-receive hook] On Mon, 27 Jan 2025 09:35:16 +0100, Ahmad Fatoum wrote: > We currently only have an option for BusyBox blkdiscard, but that one > lacks some options like -z for zeroing the block device. > > This can be important as regular discard on an eMMC isn't guaranteed > to clear data. > > Add a util-linux blkdiscard option to address this. > > Signed-off-by: Ahmad Fatoum > Message-Id: <20250123205453.2841392-1-a.fatoum@pengutronix.de> > Signed-off-by: Michael Olbrich > > diff --git a/rules/util-linux.in b/rules/util-linux.in > index 58bd21100a9e..d883fb402ca2 100644 > --- a/rules/util-linux.in > +++ b/rules/util-linux.in > @@ -62,6 +62,16 @@ config UTIL_LINUX_ADDPART > help > The addpart utility. > > +config UTIL_LINUX_BLKDISCARD > + bool > + depends on !BUSYBOX_BLKDISCARD || ALLYES > + prompt "blkdiscard" > + help > + blkdiscard is used to discard device sectors. > + > +comment "BusyBox' blkdiscard is selected!" > + depends on BUSYBOX_BLKDISCARD > + > config UTIL_LINUX_CFDISK > bool > select UTIL_LINUX_FDISKS > diff --git a/rules/util-linux.make b/rules/util-linux.make > index c98200a52258..143c7bcb78aa 100644 > --- a/rules/util-linux.make > +++ b/rules/util-linux.make > @@ -197,6 +197,7 @@ UTIL_LINUX_LIB-$(PTXCONF_UTIL_LINUX_LIBFDISK) += fdisk > > # disk-utils > UTIL_LINUX_BIN-$(PTXCONF_UTIL_LINUX_ADDPART) += sbin/addpart > +UTIL_LINUX_BIN-$(PTXCONF_UTIL_LINUX_BLKDISCARD) += sbin/blkdiscard > UTIL_LINUX_BIN-$(PTXCONF_UTIL_LINUX_CFDISK) += sbin/cfdisk > UTIL_LINUX_BIN-$(PTXCONF_UTIL_LINUX_DELPART) += sbin/delpart > UTIL_LINUX_BIN-$(PTXCONF_UTIL_LINUX_RESIZEPART) += sbin/resizepart