From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 27 Jan 2025 09:35:57 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tcKb6-0052G2-2b for lore@lore.pengutronix.de; Mon, 27 Jan 2025 09:35:57 +0100 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1tcKb6-0007Sp-Lt; Mon, 27 Jan 2025 09:35:56 +0100 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tcKaS-0005jR-0u; Mon, 27 Jan 2025 09:35:16 +0100 Received: from dude05.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::54]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tcKaR-0025uj-2h; Mon, 27 Jan 2025 09:35:15 +0100 Received: from mol by dude05.red.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1tcKaR-001WVB-2Z; Mon, 27 Jan 2025 09:35:15 +0100 From: Michael Olbrich To: ptxdist@pengutronix.de Date: Mon, 27 Jan 2025 09:35:15 +0100 Message-Id: <20250127083515.363258-1-m.olbrich@pengutronix.de> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250123-blkdiscard-v1-1-a8a4541186d5@pengutronix.de> References: <20250123-blkdiscard-v1-1-a8a4541186d5@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [ptxdist] [APPLIED] util-linux: make blkdiscard selectable X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: Jonas Rebmann Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false Thanks, applied as fc9e466c9b74d524d3c9a62eaaa5e7f80a4e3cad. Michael [sent from post-receive hook] On Mon, 27 Jan 2025 09:35:15 +0100, Jonas Rebmann wrote: > Signed-off-by: Jonas Rebmann > Message-Id: <20250123-blkdiscard-v1-1-a8a4541186d5@pengutronix.de> > Signed-off-by: Michael Olbrich > > diff --git a/rules/util-linux.in b/rules/util-linux.in > index 8bf035f3901e..58bd21100a9e 100644 > --- a/rules/util-linux.in > +++ b/rules/util-linux.in > @@ -290,6 +290,18 @@ comment "BusyBox' taskset is selected!" > > comment "sys-utils" > > +config UTIL_LINUX_BLKDISCARD > + bool > + depends on !BUSYBOX_BLKDISCARD || ALLYES > + prompt "blkdiscard" > + help > + blkdiscard is used to discard device sectors. This is useful for > + solid-state drivers (SSDs) and thinly-provisioned storage. Unlike > + fstrim, this command is used directly on the block device. > + > +comment "BusyBox' blkdiscard is selected!" > + depends on BUSYBOX_BLKDISCARD > + > config UTIL_LINUX_CHMEM > bool > prompt "chmem" > diff --git a/rules/util-linux.make b/rules/util-linux.make > index 579c165e6edb..c98200a52258 100644 > --- a/rules/util-linux.make > +++ b/rules/util-linux.make > @@ -54,7 +54,7 @@ UTIL_LINUX_CONF_OPT := \ > -Dbuild-agetty=$(call ptx/endis, PTXCONF_UTIL_LINUX_AGETTY)d \ > -Dbuild-bash-completion=disabled \ > -Dbuild-bfs=disabled \ > - -Dbuild-blkdiscard=disabled \ > + -Dbuild-blkdiscard=$(call ptx/endis, PTXCONF_UTIL_LINUX_BLKDISCARD)d \ > -Dbuild-blkpr=disabled \ > -Dbuild-blkzone=disabled \ > -Dbuild-blockdev=disabled \ > @@ -223,6 +223,7 @@ UTIL_LINUX_BIN-$(PTXCONF_UTIL_LINUX_CHRT) += bin/chrt > UTIL_LINUX_BIN-$(PTXCONF_UTIL_LINUX_IONICE) += bin/ionice > UTIL_LINUX_BIN-$(PTXCONF_UTIL_LINUX_TASKSET) += bin/taskset > # sys-utils > +UTIL_LINUX_BIN-$(PTXCONF_UTIL_LINUX_BLKDISCARD) += sbin/blkdiscard > UTIL_LINUX_BIN-$(PTXCONF_UTIL_LINUX_CHMEM) += bin/chmem > UTIL_LINUX_BIN-$(PTXCONF_UTIL_LINUX_DMESG) += bin/dmesg > UTIL_LINUX_BIN-$(PTXCONF_UTIL_LINUX_FLOCK) += bin/flock