From mboxrd@z Thu Jan  1 00:00:00 1970
Delivery-date: Thu, 16 Jan 2025 17:10:51 +0100
Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104])
	by lore.white.stw.pengutronix.de with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <ptxdist-bounces+lore=lore.pengutronix.de@pengutronix.de>)
	id 1tYSSI-000exk-14
	for lore@lore.pengutronix.de;
	Thu, 16 Jan 2025 17:10:51 +0100
Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de)
	by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92)
	(envelope-from <ptxdist-bounces@pengutronix.de>)
	id 1tYSSI-0003zr-L5; Thu, 16 Jan 2025 17:10:50 +0100
Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2])
 by metis.whiteo.stw.pengutronix.de with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92)
 (envelope-from <mol@pengutronix.de>)
 id 1tYSRB-0001lv-6v; Thu, 16 Jan 2025 17:09:41 +0100
Received: from dude05.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::54])
 by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96)
 (envelope-from <mol@pengutronix.de>) id 1tYSRB-000HU1-05;
 Thu, 16 Jan 2025 17:09:41 +0100
Received: from mol by dude05.red.stw.pengutronix.de with local (Exim 4.96)
 (envelope-from <mol@pengutronix.de>) id 1tYSRA-001nCe-3A;
 Thu, 16 Jan 2025 17:09:40 +0100
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Date: Thu, 16 Jan 2025 17:09:40 +0100
Message-Id: <20250116160940.427457-1-m.olbrich@pengutronix.de>
X-Mailer: git-send-email 2.39.5
In-Reply-To: <20250103150647.136289-2-m.heidelberg@cab.de>
References: <20250103150647.136289-2-m.heidelberg@cab.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: Re: [ptxdist] [APPLIED] ptxdist: remove superfluous deletion of
 logs in distclean action
X-BeenThere: ptxdist@pengutronix.de
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <https://metis.pengutronix.de/mailman/options/ptxdist>,
 <mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <https://metis.pengutronix.de/mailman/private/ptxdist/>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <https://metis.pengutronix.de/mailman/listinfo/ptxdist>,
 <mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Reply-To: ptxdist@pengutronix.de
Cc: Markus Heidelberg <m.heidelberg@cab.de>
Sender: "ptxdist" <ptxdist-bounces@pengutronix.de>
X-SA-Exim-Connect-IP: 127.0.0.1
X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de
X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false

Thanks, applied as 4db4d8ffe9dd2a78d938d8bd5fc3085219dbf5b7.

Michael

[sent from post-receive hook]

On Thu, 16 Jan 2025 17:09:40 +0100, Markus Heidelberg <m.heidelberg@cab.de> wrote:
> There is always a platform build directory, the logfile is not created
> in BSP root ($PTXDIST_WORKSPACE/logfile) anymore since commit
> 83bf2580f8 ("[ptxdist] always use a platform dir", 2010-11-15).
> 
> Furthermore, $PTX_LOGFILE is already deleted in clean() invoked at the
> beginning of the "distclean" action, so the whole rm command is
> unnecessary.
> 
> Also remove "logfile" from ignore rules, it is only created in the
> platform build directory of the BSP, not in the PTXdist tree.
> 
> Signed-off-by: Markus Heidelberg <m.heidelberg@cab.de>
> Message-Id: <20250103150647.136289-2-m.heidelberg@cab.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/.gitignore b/.gitignore
> index 50bfa5185269..23623fdb5806 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -13,8 +13,6 @@
>  \#*#
>  .\#*
>  
> -logfile
> -
>  /bin/*
>  !/bin/ptxdist
>  !/bin/ptxdist-auto-version
> diff --git a/bin/ptxdist b/bin/ptxdist
> index 08d7f03c476b..1f561fdf69c3 100755
> --- a/bin/ptxdist
> +++ b/bin/ptxdist
> @@ -1815,9 +1815,6 @@ EOF
>  				fi
>  			done
>  
> -			echo "${PTXDIST_LOG_PROMPT}removing logs..."
> -			rm -f -- "${PTX_LOGFILE}" "${PTXDIST_WORKSPACE}/logfile"
> -
>  			echo
>  			exit
>  			;;