From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Markus Heidelberg <m.heidelberg@cab.de>
Subject: Re: [ptxdist] [APPLIED] ptxdist: remove superfluous deletion of logs in distclean action
Date: Thu, 16 Jan 2025 17:09:40 +0100 [thread overview]
Message-ID: <20250116160940.427457-1-m.olbrich@pengutronix.de> (raw)
In-Reply-To: <20250103150647.136289-2-m.heidelberg@cab.de>
Thanks, applied as 4db4d8ffe9dd2a78d938d8bd5fc3085219dbf5b7.
Michael
[sent from post-receive hook]
On Thu, 16 Jan 2025 17:09:40 +0100, Markus Heidelberg <m.heidelberg@cab.de> wrote:
> There is always a platform build directory, the logfile is not created
> in BSP root ($PTXDIST_WORKSPACE/logfile) anymore since commit
> 83bf2580f8 ("[ptxdist] always use a platform dir", 2010-11-15).
>
> Furthermore, $PTX_LOGFILE is already deleted in clean() invoked at the
> beginning of the "distclean" action, so the whole rm command is
> unnecessary.
>
> Also remove "logfile" from ignore rules, it is only created in the
> platform build directory of the BSP, not in the PTXdist tree.
>
> Signed-off-by: Markus Heidelberg <m.heidelberg@cab.de>
> Message-Id: <20250103150647.136289-2-m.heidelberg@cab.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
>
> diff --git a/.gitignore b/.gitignore
> index 50bfa5185269..23623fdb5806 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -13,8 +13,6 @@
> \#*#
> .\#*
>
> -logfile
> -
> /bin/*
> !/bin/ptxdist
> !/bin/ptxdist-auto-version
> diff --git a/bin/ptxdist b/bin/ptxdist
> index 08d7f03c476b..1f561fdf69c3 100755
> --- a/bin/ptxdist
> +++ b/bin/ptxdist
> @@ -1815,9 +1815,6 @@ EOF
> fi
> done
>
> - echo "${PTXDIST_LOG_PROMPT}removing logs..."
> - rm -f -- "${PTX_LOGFILE}" "${PTXDIST_WORKSPACE}/logfile"
> -
> echo
> exit
> ;;
next prev parent reply other threads:[~2025-01-16 16:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-03 15:06 [ptxdist] [PATCH 1/2] ptxdist: really remove the logfile during " Markus Heidelberg
2025-01-03 15:06 ` [ptxdist] [PATCH 2/2] ptxdist: remove superfluous deletion of logs in " Markus Heidelberg
2025-01-16 16:09 ` Michael Olbrich [this message]
2025-01-16 16:09 ` [ptxdist] [APPLIED] ptxdist: really remove the logfile during " Michael Olbrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250116160940.427457-1-m.olbrich@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=m.heidelberg@cab.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox