From mboxrd@z Thu Jan  1 00:00:00 1970
Delivery-date: Thu, 16 Jan 2025 17:10:43 +0100
Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104])
	by lore.white.stw.pengutronix.de with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <ptxdist-bounces+lore=lore.pengutronix.de@pengutronix.de>)
	id 1tYSSA-000exL-2v
	for lore@lore.pengutronix.de;
	Thu, 16 Jan 2025 17:10:43 +0100
Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de)
	by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92)
	(envelope-from <ptxdist-bounces@pengutronix.de>)
	id 1tYSSB-0003ih-Cp; Thu, 16 Jan 2025 17:10:43 +0100
Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2])
 by metis.whiteo.stw.pengutronix.de with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92)
 (envelope-from <mol@pengutronix.de>)
 id 1tYSRA-0001lc-Hc; Thu, 16 Jan 2025 17:09:40 +0100
Received: from dude05.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::54])
 by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96)
 (envelope-from <mol@pengutronix.de>) id 1tYSRA-000HTx-0x;
 Thu, 16 Jan 2025 17:09:40 +0100
Received: from mol by dude05.red.stw.pengutronix.de with local (Exim 4.96)
 (envelope-from <mol@pengutronix.de>) id 1tYSRA-001nBy-0p;
 Thu, 16 Jan 2025 17:09:40 +0100
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Date: Thu, 16 Jan 2025 17:09:40 +0100
Message-Id: <20250116160940.427415-1-m.olbrich@pengutronix.de>
X-Mailer: git-send-email 2.39.5
In-Reply-To: <20250103150647.136289-1-m.heidelberg@cab.de>
References: <20250103150647.136289-1-m.heidelberg@cab.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: Re: [ptxdist] [APPLIED] ptxdist: really remove the logfile during
 distclean action
X-BeenThere: ptxdist@pengutronix.de
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <https://metis.pengutronix.de/mailman/options/ptxdist>,
 <mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <https://metis.pengutronix.de/mailman/private/ptxdist/>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <https://metis.pengutronix.de/mailman/listinfo/ptxdist>,
 <mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Reply-To: ptxdist@pengutronix.de
Cc: Markus Heidelberg <m.heidelberg@cab.de>
Sender: "ptxdist" <ptxdist-bounces@pengutronix.de>
X-SA-Exim-Connect-IP: 127.0.0.1
X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de
X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false

Thanks, applied as 23d7d9fecdf86ff22d1576e57eaf0add7e6fde96.

Michael

[sent from post-receive hook]

On Thu, 16 Jan 2025 17:09:40 +0100, Markus Heidelberg <m.heidelberg@cab.de> wrote:
> In contrast to "ptxdist clean", "ptxdist distclean" did not remove
> $PTX_LOGFILE. The variable wasn't yet initialized when calling clean()
> wherein the logfile should have been removed.
> 
> Signed-off-by: Markus Heidelberg <m.heidelberg@cab.de>
> Message-Id: <20250103150647.136289-1-m.heidelberg@cab.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/bin/ptxdist b/bin/ptxdist
> index 1503d2e33170..08d7f03c476b 100755
> --- a/bin/ptxdist
> +++ b/bin/ptxdist
> @@ -1798,6 +1798,7 @@ EOF
>  			exit
>  			;;
>  		distclean)
> +			setup_logfile &&
>  			clean
>  
>  			echo "${PTXDIST_LOG_PROMPT}removing configuration links..."