mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Markus Heidelberg <m.heidelberg@cab.de>
Subject: Re: [ptxdist] [APPLIED] ptxdist: really remove the logfile during distclean action
Date: Thu, 16 Jan 2025 17:09:40 +0100	[thread overview]
Message-ID: <20250116160940.427415-1-m.olbrich@pengutronix.de> (raw)
In-Reply-To: <20250103150647.136289-1-m.heidelberg@cab.de>

Thanks, applied as 23d7d9fecdf86ff22d1576e57eaf0add7e6fde96.

Michael

[sent from post-receive hook]

On Thu, 16 Jan 2025 17:09:40 +0100, Markus Heidelberg <m.heidelberg@cab.de> wrote:
> In contrast to "ptxdist clean", "ptxdist distclean" did not remove
> $PTX_LOGFILE. The variable wasn't yet initialized when calling clean()
> wherein the logfile should have been removed.
> 
> Signed-off-by: Markus Heidelberg <m.heidelberg@cab.de>
> Message-Id: <20250103150647.136289-1-m.heidelberg@cab.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/bin/ptxdist b/bin/ptxdist
> index 1503d2e33170..08d7f03c476b 100755
> --- a/bin/ptxdist
> +++ b/bin/ptxdist
> @@ -1798,6 +1798,7 @@ EOF
>  			exit
>  			;;
>  		distclean)
> +			setup_logfile &&
>  			clean
>  
>  			echo "${PTXDIST_LOG_PROMPT}removing configuration links..."



      parent reply	other threads:[~2025-01-16 16:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-03 15:06 [ptxdist] [PATCH 1/2] " Markus Heidelberg
2025-01-03 15:06 ` [ptxdist] [PATCH 2/2] ptxdist: remove superfluous deletion of logs in " Markus Heidelberg
2025-01-16 16:09   ` [ptxdist] [APPLIED] " Michael Olbrich
2025-01-16 16:09 ` Michael Olbrich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250116160940.427415-1-m.olbrich@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=m.heidelberg@cab.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox