mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Marc Kleine-Budde <mkl@pengutronix.de>
Subject: Re: [ptxdist] [APPLIED] ptxd_install_compression_format: don't use host readelf to figure out debug compression format
Date: Thu, 16 Jan 2025 17:09:33 +0100	[thread overview]
Message-ID: <20250116160933.426987-1-m.olbrich@pengutronix.de> (raw)
In-Reply-To: <20241218-fix-ptxd_install_compression_format-v1-1-8b4973b0bb55@pengutronix.de>

Thanks, applied as 21f4c86df87fcf2e5e17c732804d2afbc440eb4e.

Michael

[sent from post-receive hook]

On Thu, 16 Jan 2025 17:09:33 +0100, Marc Kleine-Budde <mkl@pengutronix.de> wrote:
> The host readelf might be too old and doesn't understand the
> compression formats of new toolchain libraries. This leads to the
> following error:
> 
> | readelf: Warning: section '.debug_str' has unsupported compress type: 2
> 
> Use coss-readelf of toolchain instead.
> 
> Fixes: baf33e7186cb ("ptxd_install_file_extract_debug: pick the debug compression format from the toolchain")
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> Message-Id: <20241218-fix-ptxd_install_compression_format-v1-1-8b4973b0bb55@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/scripts/lib/ptxd_make_xpkg_pkg.sh b/scripts/lib/ptxd_make_xpkg_pkg.sh
> index 08a0ab593feb..6d2d2fcafa65 100644
> --- a/scripts/lib/ptxd_make_xpkg_pkg.sh
> +++ b/scripts/lib/ptxd_make_xpkg_pkg.sh
> @@ -390,7 +390,7 @@ ptxd_install_compression_format() {
>  
>      libc="$(ptxd_cross_cc -print-file-name=libc.so.6 2> /dev/null)"
>      if [ -n "${libc}" ]; then
> -	comp="=$(readelf -t "${libc}" | sed -n -e '/COMPRESSED/{N;s/.*\(ZLIB\|ZSTD\).*/\1/p;q}' | tr '[:upper:]' '[:lower:]')"
> +	comp="=$($(ptxd_get_ptxconf PTXCONF_COMPILER_PREFIX)readelf -t "${libc}" | sed -n -e '/COMPRESSED/{N;s/.*\(ZLIB\|ZSTD\).*/\1/p;q}' | tr '[:upper:]' '[:lower:]')"
>      fi
>      export ptxd_install_file_objcopy_args="--only-keep-debug --compress-debug-sections${comp}"
>  }



      reply	other threads:[~2025-01-16 16:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-18 15:16 [ptxdist] [PATCH] " Marc Kleine-Budde
2025-01-16 16:09 ` Michael Olbrich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250116160933.426987-1-m.olbrich@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=mkl@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox