From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 03 Jan 2025 16:07:37 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tTjGy-00GFaN-1h for lore@lore.pengutronix.de; Fri, 03 Jan 2025 16:07:37 +0100 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1tTjGy-0005dt-Lt; Fri, 03 Jan 2025 16:07:36 +0100 Received: from mail.cab.de ([46.232.229.101]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tTjGi-0005dE-8R for ptxdist@pengutronix.de; Fri, 03 Jan 2025 16:07:21 +0100 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.cab.de 4YPn472XHlzMvQtR DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cab.de; s=default; t=1735916839; bh=EzIXXnmeCJtcIkXK2Cv1TWrExABTkFQ143ebDnDpfd4=; h=From:To:CC:Subject:Date:From; b=RJMuVKo0wvrzIk+4l57FbbHdDzTf+8fpq3mc0CFNEcE4SSvbAMO/cbNACgHZ6ffiV pvOmKYASGfnEsXHeJ1yTG6VoKLvqaBvZq6bFhznDnsPBxX0la4hlwz1DT5nGqWkgv5 Dx25ebckSh9gJ9U1Ti8FxiNSWHws4xfF4J1MoDnw= X-cab-MailScanner-Watermark: 1736521638.49124@C7DiNBsEgcvTogrc298Nhw X-cab-MailScanner-From: m.heidelberg@cab.de X-cab-MailScanner: Found to be clean X-cab-MailScanner-ID: 4YPn453ZPbzMvQwP X-cab-MailScanner-Information: Please contact it@cab.de for more information Received: from Adranos.cab.de ([10.10.1.54] [10.10.1.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (no client certificate requested) by hephaistos.cab.de (MailScanner Milter) with SMTP id 4YPn453ZPbzMvQwP for ; Fri, 3 Jan 2025 16:07:17 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.cab.de 4YPn453ZPbzMvQwP Received: from KAN23-025.cab.de (10.10.3.178) by Adranos.cab.de (10.10.1.54) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Fri, 3 Jan 2025 16:07:16 +0100 From: Markus Heidelberg To: Date: Fri, 3 Jan 2025 16:06:46 +0100 Message-ID: <20250103150647.136289-1-m.heidelberg@cab.de> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.10.3.178] X-ClientProxiedBy: Adranos.cab.de (10.10.1.54) To Adranos.cab.de (10.10.1.54) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=4.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Subject: [ptxdist] [PATCH 1/2] ptxdist: really remove the logfile during distclean action X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: Markus Heidelberg Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false In contrast to "ptxdist clean", "ptxdist distclean" did not remove $PTX_LOGFILE. The variable wasn't yet initialized when calling clean() wherein the logfile should have been removed. Signed-off-by: Markus Heidelberg --- I'm unsure whether this is the right fix, but without it my description of the next patch would be partly untrue. Maybe it was a regression introduced in commit 9f8e963a2c6 ("ptxdist: don't create the logfile until the platformdir is verified", 2014-02-23). bin/ptxdist | 1 + 1 file changed, 1 insertion(+) diff --git a/bin/ptxdist b/bin/ptxdist index 1503d2e33..08d7f03c4 100755 --- a/bin/ptxdist +++ b/bin/ptxdist @@ -1798,6 +1798,7 @@ EOF exit ;; distclean) + setup_logfile && clean echo "${PTXDIST_LOG_PROMPT}removing configuration links..." -- 2.43.0