mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Markus Heidelberg <m.heidelberg@cab.de>
To: <ptxdist@pengutronix.de>
Cc: Markus Heidelberg <m.heidelberg@cab.de>
Subject: [ptxdist] [PATCH 1/2] ptxdist: really remove the logfile during distclean action
Date: Fri, 3 Jan 2025 16:06:46 +0100	[thread overview]
Message-ID: <20250103150647.136289-1-m.heidelberg@cab.de> (raw)

In contrast to "ptxdist clean", "ptxdist distclean" did not remove
$PTX_LOGFILE. The variable wasn't yet initialized when calling clean()
wherein the logfile should have been removed.

Signed-off-by: Markus Heidelberg <m.heidelberg@cab.de>
---


I'm unsure whether this is the right fix, but without it my description
of the next patch would be partly untrue.

Maybe it was a regression introduced in commit 9f8e963a2c6 ("ptxdist:
don't create the logfile until the platformdir is verified",
2014-02-23).


 bin/ptxdist | 1 +
 1 file changed, 1 insertion(+)

diff --git a/bin/ptxdist b/bin/ptxdist
index 1503d2e33..08d7f03c4 100755
--- a/bin/ptxdist
+++ b/bin/ptxdist
@@ -1798,6 +1798,7 @@ EOF
 			exit
 			;;
 		distclean)
+			setup_logfile &&
 			clean
 
 			echo "${PTXDIST_LOG_PROMPT}removing configuration links..."
-- 
2.43.0





             reply	other threads:[~2025-01-03 15:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-03 15:06 Markus Heidelberg [this message]
2025-01-03 15:06 ` [ptxdist] [PATCH 2/2] ptxdist: remove superfluous deletion of logs in " Markus Heidelberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250103150647.136289-1-m.heidelberg@cab.de \
    --to=m.heidelberg@cab.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox