mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Michael Grzeschik <m.grzeschik@pengutronix.de>
Subject: Re: [ptxdist] [APPLIED] scripts: lib: ptxd_lib_code_signing: use pkey instead of rsa
Date: Fri, 25 Oct 2024 09:32:54 +0200	[thread overview]
Message-ID: <20241025073254.2195860-1-m.olbrich@pengutronix.de> (raw)
In-Reply-To: <20241010233115.98774-1-m.grzeschik@pengutronix.de>

Thanks, applied as 363a007e38bcfb9205c5e8fb1787aad1f021f1ce.

Michael

[sent from post-receive hook]

On Fri, 25 Oct 2024 09:32:54 +0200, Michael Grzeschik <m.grzeschik@pengutronix.de> wrote:
> This way openssl will automatically detect the used algorithm
> of the pem and the helper is not limited to rsa.
> 
> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
> Message-Id: <20241010233115.98774-1-m.grzeschik@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/scripts/lib/ptxd_lib_code_signing.sh b/scripts/lib/ptxd_lib_code_signing.sh
> index bafdc16544d3..a98596b28651 100644
> --- a/scripts/lib/ptxd_lib_code_signing.sh
> +++ b/scripts/lib/ptxd_lib_code_signing.sh
> @@ -233,7 +233,7 @@ cs_import_pubkey_from_pem() {
>  	openssl_keyopt=( -passin "file:${OPENSSL_KEYPASS}" )
>      fi
>  
> -    openssl rsa \
> +    openssl pkey \
>  	"${openssl_keyopt[@]}" \
>  	-in "${pem}" -inform pem -pubout -outform der |
>      softhsm_pkcs11_tool --type pubkey --write-object /dev/stdin --label "${role}"
> @@ -257,7 +257,7 @@ cs_import_privkey_from_pem() {
>  	openssl_keyopt=( -passin "file:${OPENSSL_KEYPASS}" )
>      fi
>  
> -    openssl rsa \
> +    openssl pkey \
>  	"${openssl_keyopt[@]}" \
>  	-in "${pem}" -inform pem -outform der |
>      softhsm_pkcs11_tool --type privkey --write-object /dev/stdin --label "${role}"



      reply	other threads:[~2024-10-25  7:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-10 23:31 [ptxdist] [PATCH] " Michael Grzeschik
2024-10-25  7:32 ` Michael Olbrich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241025073254.2195860-1-m.olbrich@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=m.grzeschik@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox