From mboxrd@z Thu Jan  1 00:00:00 1970
Delivery-date: Mon, 16 Sep 2024 16:35:02 +0200
Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104])
	by lore.white.stw.pengutronix.de with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <ptxdist-bounces+lore=lore.pengutronix.de@pengutronix.de>)
	id 1sqCog-0056N6-2F
	for lore@lore.pengutronix.de;
	Mon, 16 Sep 2024 16:35:02 +0200
Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de)
	by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92)
	(envelope-from <ptxdist-bounces@pengutronix.de>)
	id 1sqCof-0006NH-Ql; Mon, 16 Sep 2024 16:35:01 +0200
Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2])
 by metis.whiteo.stw.pengutronix.de with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92)
 (envelope-from <mol@pengutronix.de>)
 id 1sqCns-0005Kd-Ur; Mon, 16 Sep 2024 16:34:12 +0200
Received: from [2a0a:edc0:0:1101:1d::54] (helo=dude05.red.stw.pengutronix.de)
 by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2)
 (envelope-from <mol@pengutronix.de>)
 id 1sqCns-008L9r-IK; Mon, 16 Sep 2024 16:34:12 +0200
Received: from mol by dude05.red.stw.pengutronix.de with local (Exim 4.96)
 (envelope-from <mol@pengutronix.de>) id 1sqCns-00CJBO-1f;
 Mon, 16 Sep 2024 16:34:12 +0200
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Date: Mon, 16 Sep 2024 16:34:12 +0200
Message-Id: <20240916143412.2933659-1-m.olbrich@pengutronix.de>
X-Mailer: git-send-email 2.39.5
In-Reply-To: <20240912085725.1864129-1-m.tretter@pengutronix.de>
References: <20240912085725.1864129-1-m.tretter@pengutronix.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: Re: [ptxdist] [APPLIED] bluez: cleanup default configuration values
X-BeenThere: ptxdist@pengutronix.de
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <https://metis.pengutronix.de/mailman/options/ptxdist>,
 <mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <https://metis.pengutronix.de/mailman/private/ptxdist/>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <https://metis.pengutronix.de/mailman/listinfo/ptxdist>,
 <mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Reply-To: ptxdist@pengutronix.de
Cc: Michael Tretter <m.tretter@pengutronix.de>
Sender: "ptxdist" <ptxdist-bounces@pengutronix.de>
X-SA-Exim-Connect-IP: 127.0.0.1
X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de
X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false

Thanks, applied as d15d8398f468218b122405f1937ff33c878e996a.

Michael

[sent from post-receive hook]

On Mon, 16 Sep 2024 16:34:12 +0200, Michael Tretter <m.tretter@pengutronix.de> wrote:
> Use the special value "no" to actually disable the zsh completions
> instead of using an empty path.
> 
> Use the value "dummy" for the phonebook, which bluez uses to internally
> to replace an empty string, and make the default explicit.
> 
> Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
> Message-Id: <20240912085725.1864129-1-m.tretter@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/rules/bluez.make b/rules/bluez.make
> index 7838a096e0ed..d0c3a2f7399b 100644
> --- a/rules/bluez.make
> +++ b/rules/bluez.make
> @@ -88,11 +88,11 @@ BLUEZ_CONF_OPT	:= $(CROSS_AUTOCONF_USR) \
>  	--with-dbusconfdir=/usr/share \
>  	--with-dbussystembusdir=/usr/share/dbus-1/system-services \
>  	--with-dbussessionbusdir=/usr/share/dbus-1/services \
> -	--with-zsh-completion-dir= \
> +	--with-zsh-completion-dir=no \
>  	--with-udevdir=/usr/lib/udev \
>  	--with-systemdsystemunitdir=/usr/lib/systemd/system \
>  	--with-systemduserunitdir=/usr/lib/systemd/user \
> -	--with-phonebook=
> +	--with-phonebook=dummy
>  
>  # ----------------------------------------------------------------------------
>  # Target-Install