From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 12 Sep 2024 14:23:44 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1soirQ-003n8e-2t for lore@lore.pengutronix.de; Thu, 12 Sep 2024 14:23:44 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1soirQ-0007CP-4a; Thu, 12 Sep 2024 14:23:44 +0200 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1soigU-0003EA-1Y; Thu, 12 Sep 2024 14:12:26 +0200 Received: from [2a0a:edc0:0:1101:1d::54] (helo=dude05.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1soigT-007NU9-Ky; Thu, 12 Sep 2024 14:12:25 +0200 Received: from mol by dude05.red.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1soigT-00BHdV-1x; Thu, 12 Sep 2024 14:12:25 +0200 From: Michael Olbrich To: ptxdist@pengutronix.de Date: Thu, 12 Sep 2024 14:12:25 +0200 Message-Id: <20240912121225.2689394-1-m.olbrich@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240910105459.3468520-1-ada@thorsis.com> References: <20240910105459.3468520-1-ada@thorsis.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: [ptxdist] [APPLIED] util-linux: Enable libutil for pre glibc 2.34 toolchains X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: Alexander Dahl Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false Thanks, applied as dd466b0a49919f31ea7d401576b05bb20488bbf7. Michael [sent from post-receive hook] On Thu, 12 Sep 2024 14:12:25 +0200, Alexander Dahl wrote: > Otherwise we get linker errors like this (e.g. with > OSELAS.Toolchain-2020.08 coming with glibc 2.32): >=20 > % p -v -j1 compile util-linux >=20 > -------------------------- > target: util-linux.compile > -------------------------- >=20 > ptxdist: executing: PATH=3D/home/adahl/Work/bsp/thorsis/ncl/tmp/platf= orm-ncl/sysroot-cross/usr/bin:/home/adahl/Work/bsp/thorsis/ncl/tmp/platform= -ncl/sysroot-cross/usr/sbin:/home/adahl/Work/bsp/thorsis/ncl/tmp/platform-n= cl/sysroot-host/usr/lib/wrapper:/home/adahl/Work/bsp/thorsis/ncl/tmp/platfo= rm-ncl/sysroot-host/usr/bin:/home/adahl/Work/bsp/thorsis/ncl/tmp/platform-n= cl/sysroot-host/usr/sbin:/home/adahl/Work/bsp/thorsis/ncl/tmp/selected_tool= chain:/usr/local/lib/ptxdist-2024.05.0/bin:/home/adahl/Work/bsp/thorsis/ncl= /tmp/platform-ncl/sysroot-host/usr/bin:/home/adahl/Work/bsp/thorsis/ncl/tmp= /platform-ncl/sysroot-host/usr/sbin:/home/adahl/Work/bsp/thorsis/ncl/tmp/se= lected_toolchain:/usr/local/lib/ptxdist-2024.04.0/bin:/home/adahl/bin:/home= /adahl/.local/bin:/usr/local/bin:/usr/bin:/bin:/usr/games HTTPS_PROXY=3DPTX= DIST-UNALLOWED-DOWNLOAD HTTP_PROXY=3DPTXDIST-UNALLOWED-DOWNLOAD https_proxy= =3DPTXDIST-UNALLOWED-DOWNLOAD http_proxy=3DPTXDIST-UNALLOWED-DOWNLOAD PKGCO= NFIG_WHITELIST_HOST=3D'' PKGCONFIG_WHITELIST_TARGET=3D'' PKGCONFIG_WHITELIS= T_SRC=3D'util-linux' SYSROOT=3D'/home/adahl/Work/bsp/thorsis/ncl/tmp/platfo= rm-ncl/sysroot-target' V=3D1 VERBOSE=3D1 LC_ALL=3D'C.utf8' KBUILD_BUILD_TIM= ESTAMP=3D2020-08-01T00:00:00+00:00 KBUILD_BUILD_USER=3Dptxdist KBUILD_BUILD= _HOST=3Dptxdist ninja -C /home/adahl/Work/bsp/thorsis/ncl/tmp/platform-ncl= /build-target/util-linux-2.40.2-build -v -j1 >=20 > ninja: Entering directory `/home/adahl/Work/bsp/thorsis/ncl/tmp/platf= orm-ncl/build-target/util-linux-2.40.2-build' > [1/75] arm-v5te-linux-gnueabi-gcc -o test_pty test_pty.p/lib_pty-ses= sion.c.o test_pty.p/lib_monotonic.c.o -Wl,--as-needed -Wl,--no-undefined -W= l,--start-group lib/libcommon.a -lm -lrt -Wl,--end-group > FAILED: test_pty > arm-v5te-linux-gnueabi-gcc -o test_pty test_pty.p/lib_pty-session.c.= o test_pty.p/lib_monotonic.c.o -Wl,--as-needed -Wl,--no-undefined -Wl,--sta= rt-group lib/libcommon.a -lm -lrt -Wl,--end-group > /opt/OSELAS.Toolchain-2020.08.0/arm-v5te-linux-gnueabi/gcc-10.2.1-gli= bc-2.32-binutils-2.35-kernel-5.8-sanitized/lib/gcc/arm-v5te-linux-gnueabi/1= 0.2.1/../../../../arm-v5te-linux-gnueabi/bin/ld: test_pty.p/lib_pty-session= .c.o: in function `ul_pty_setup': > platform-ncl/build-target/util-linux-2.40.2-build/../util-linux-2.40.= 2/lib/pty-session.c:198: undefined reference to `openpty' > /opt/OSELAS.Toolchain-2020.08.0/arm-v5te-linux-gnueabi/gcc-10.2.1-gli= bc-2.32-binutils-2.35-kernel-5.8-sanitized/lib/gcc/arm-v5te-linux-gnueabi/1= 0.2.1/../../../../arm-v5te-linux-gnueabi/bin/ld: platform-ncl/build-target/= util-linux-2.40.2-build/../util-linux-2.40.2/lib/pty-session.c:188: undefin= ed reference to `openpty' > collect2: error: ld returned 1 exit status > ninja: build stopped: subcommand failed. > make: *** [/usr/local/lib/ptxdist-2024.05.0/rules/post/ptxd_make_worl= d_compile.make:20: /home/adahl/Work/bsp/thorsis/ncl/tmp/platform-ncl/state/= util-linux.compile] Error 1 >=20 > Suggested-by: Michael Olbrich > Fixes: 18c9c0f89c41 ("util-linux: switch to meson") > Link: https://lore.ptxdist.org/ptxdist/ZuAYutgoVwik51tk@pengutronix.de/T/= #u > Signed-off-by: Alexander Dahl > Message-Id: <20240910105459.3468520-1-ada@thorsis.com> > Signed-off-by: Michael Olbrich >=20 > diff --git a/rules/util-linux.make b/rules/util-linux.make > index 62cd995a07e6..8cf82bd8336a 100644 > --- a/rules/util-linux.make > +++ b/rules/util-linux.make > @@ -155,7 +155,7 @@ UTIL_LINUX_CONF_OPT :=3D \ > -Dlibpcre2-posix=3Ddisabled \ > -Dlibuser=3Ddisabled \ > -Dlibutempter=3Ddisabled \ > - -Dlibutil=3Ddisabled \ > + -Dlibutil=3D$(call ptx/disen, PTXCONF_GLIBC_2_34)d \ > -Dmagic=3Ddisabled \ > -Dncurses=3D$(call ptx/endis, UTIL_LINUX_USES_NCURSES)d \ > -Dncursesw=3D$(call ptx/endis, PTXCONF_UTIL_LINUX_USES_NCURSESW)d \