From mboxrd@z Thu Jan  1 00:00:00 1970
Delivery-date: Thu, 12 Sep 2024 14:16:23 +0200
Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104])
	by lore.white.stw.pengutronix.de with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <ptxdist-bounces+lore=lore.pengutronix.de@pengutronix.de>)
	id 1soikK-003mtl-0w
	for lore@lore.pengutronix.de;
	Thu, 12 Sep 2024 14:16:23 +0200
Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de)
	by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92)
	(envelope-from <ptxdist-bounces@pengutronix.de>)
	id 1soikJ-0007UB-F7; Thu, 12 Sep 2024 14:16:23 +0200
Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2])
 by metis.whiteo.stw.pengutronix.de with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92)
 (envelope-from <mol@pengutronix.de>)
 id 1soifx-0001va-Dy; Thu, 12 Sep 2024 14:11:53 +0200
Received: from [2a0a:edc0:0:1101:1d::54] (helo=dude05.red.stw.pengutronix.de)
 by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2)
 (envelope-from <mol@pengutronix.de>)
 id 1soifx-007NRa-1D; Thu, 12 Sep 2024 14:11:53 +0200
Received: from mol by dude05.red.stw.pengutronix.de with local (Exim 4.96)
 (envelope-from <mol@pengutronix.de>) id 1soifw-00BH88-3D;
 Thu, 12 Sep 2024 14:11:52 +0200
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Date: Thu, 12 Sep 2024 14:11:52 +0200
Message-Id: <20240912121152.2687449-1-m.olbrich@pengutronix.de>
X-Mailer: git-send-email 2.39.2
In-Reply-To: <20240819200349.28458-1-bruno.thomsen@gmail.com>
References: <20240819200349.28458-1-bruno.thomsen@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: Re: [ptxdist] [APPLIED] ptxd_make_get: verbose on wget
X-BeenThere: ptxdist@pengutronix.de
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <https://metis.pengutronix.de/mailman/options/ptxdist>,
 <mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <https://metis.pengutronix.de/mailman/private/ptxdist/>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <https://metis.pengutronix.de/mailman/listinfo/ptxdist>,
 <mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Reply-To: ptxdist@pengutronix.de
Cc: Bruno Thomsen <bruno.thomsen@gmail.com>
Sender: "ptxdist" <ptxdist-bounces@pengutronix.de>
X-SA-Exim-Connect-IP: 127.0.0.1
X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de
X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false

Thanks, applied as bb412159bc1cc375ee8523280c4857ae7dab14b6.

Michael

[sent from post-receive hook]

On Thu, 12 Sep 2024 14:11:52 +0200, Bruno Thomsen <bruno.thomsen@gmail.com> wrote:
> Change wget progress to none when verbose is chosen,
> so it's possible to see download URLs.
> 
> Tested on GNU Wget2 2.1.0 (Fedora 40) and GNU Wget 1.21.4 (Ubuntu 24.04).
> 
> Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
> Message-Id: <20240819200349.28458-1-bruno.thomsen@gmail.com>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/scripts/lib/ptxd_make_get.sh b/scripts/lib/ptxd_make_get.sh
> index 4951abe5abf1..eea56f8afbab 100644
> --- a/scripts/lib/ptxd_make_get.sh
> +++ b/scripts/lib/ptxd_make_get.sh
> @@ -94,7 +94,11 @@ ptxd_make_get_http() {
>  	return
>      elif [ ! -e "${path}" ]; then
>  	temp_file="$(mktemp "${path}.XXXXXXXXXX")" || ptxd_bailout "failed to create tempfile"
> -	if [ -n "${PTXDIST_QUIET}" ]; then
> +	if [ "${PTXDIST_VERBOSE}" == "1" ]; then
> +		if wget --version | grep "GNU Wget2"; then
> +		    progress=none
> +		fi
> +	elif [ -n "${PTXDIST_QUIET}" ]; then
>  	    progress=dot
>  	else
>  	    progress=bar:force