From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Bruno Thomsen <bruno.thomsen@gmail.com>
Subject: Re: [ptxdist] [APPLIED] ptxd_make_get: verbose on wget
Date: Thu, 12 Sep 2024 14:11:52 +0200 [thread overview]
Message-ID: <20240912121152.2687449-1-m.olbrich@pengutronix.de> (raw)
In-Reply-To: <20240819200349.28458-1-bruno.thomsen@gmail.com>
Thanks, applied as bb412159bc1cc375ee8523280c4857ae7dab14b6.
Michael
[sent from post-receive hook]
On Thu, 12 Sep 2024 14:11:52 +0200, Bruno Thomsen <bruno.thomsen@gmail.com> wrote:
> Change wget progress to none when verbose is chosen,
> so it's possible to see download URLs.
>
> Tested on GNU Wget2 2.1.0 (Fedora 40) and GNU Wget 1.21.4 (Ubuntu 24.04).
>
> Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
> Message-Id: <20240819200349.28458-1-bruno.thomsen@gmail.com>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
>
> diff --git a/scripts/lib/ptxd_make_get.sh b/scripts/lib/ptxd_make_get.sh
> index 4951abe5abf1..eea56f8afbab 100644
> --- a/scripts/lib/ptxd_make_get.sh
> +++ b/scripts/lib/ptxd_make_get.sh
> @@ -94,7 +94,11 @@ ptxd_make_get_http() {
> return
> elif [ ! -e "${path}" ]; then
> temp_file="$(mktemp "${path}.XXXXXXXXXX")" || ptxd_bailout "failed to create tempfile"
> - if [ -n "${PTXDIST_QUIET}" ]; then
> + if [ "${PTXDIST_VERBOSE}" == "1" ]; then
> + if wget --version | grep "GNU Wget2"; then
> + progress=none
> + fi
> + elif [ -n "${PTXDIST_QUIET}" ]; then
> progress=dot
> else
> progress=bar:force
prev parent reply other threads:[~2024-09-12 12:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-19 20:03 [ptxdist] [PATCH v2] " Bruno Thomsen
2024-09-12 12:11 ` Michael Olbrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240912121152.2687449-1-m.olbrich@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=bruno.thomsen@gmail.com \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox