From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Markus Heidelberg <m.heidelberg@cab.de>
Subject: Re: [ptxdist] [APPLIED] ptxd_make_world_patchin_apply_git_init: only invoke rebase helper when needed
Date: Thu, 12 Sep 2024 14:11:40 +0200 [thread overview]
Message-ID: <20240912121140.2685638-1-m.olbrich@pengutronix.de> (raw)
In-Reply-To: <20240809090817.45817-1-m.heidelberg@cab.de>
Thanks, applied as fa4349755a225c177a9afe7eba294ba301ce6525.
Michael
[sent from post-receive hook]
On Thu, 12 Sep 2024 14:11:40 +0200, Markus Heidelberg <m.heidelberg@cab.de> wrote:
> Originally it was only invoked during interactive rebase, but the needed
> git config variable sequence.editor had been accidentally reverted to
> the previous state core.editor in commit f4d2f09da9df
> ("ptxd_make_world_patchin: Allow git-ptx-* scripts to be overwritten",
> 2023-06-19), so it was always invoked before the normal user editor.
>
> Since the helper script "git-ptx-refresh-tags-editor" mangles
> whitespace, e.g. the "e" command of "git add --patch" for manually
> editing hunks didn't work anymore because the patch opened in the editor
> was corrupt.
>
> Signed-off-by: Markus Heidelberg <m.heidelberg@cab.de>
> Message-Id: <20240809090817.45817-1-m.heidelberg@cab.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
>
> diff --git a/scripts/lib/ptxd_make_world_patchin.sh b/scripts/lib/ptxd_make_world_patchin.sh
> index 8fde0e24c1c8..d13f18d4325c 100644
> --- a/scripts/lib/ptxd_make_world_patchin.sh
> +++ b/scripts/lib/ptxd_make_world_patchin.sh
> @@ -79,7 +79,7 @@ ptxd_make_world_patchin_apply_git_init()
> __git tag "${pkg_pkg//\~/-}" &&
> __git tag base &&
> __git config alias.ptx-patches "!${git_ptx_patches} \"\${@}\"" &&
> - __git config core.editor "${git_ptx_refresh_tags_editor}" &&
> + __git config sequence.editor "${git_ptx_refresh_tags_editor}" &&
> __git config diff.renames false &&
> __git config core.abbrev 12 &&
> __git config core.autocrlf false &&
prev parent reply other threads:[~2024-09-12 12:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-09 9:08 [ptxdist] [PATCH] " Markus Heidelberg
2024-09-12 12:11 ` Michael Olbrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240912121140.2685638-1-m.olbrich@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=m.heidelberg@cab.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox