[ptxdist] [PATCH] bluez: cleanup default configuration values

[ptxdist] [PATCH] bluez: cleanup default configuration values

[Michael Tretter]

Use the special value "no" to actually disable the zsh completions
instead of using an empty path.

Use the value "dummy" for the phonebook, which bluez uses to internally
to replace an empty string, and make the default explicit.

Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
---
 rules/bluez.make | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/rules/bluez.make b/rules/bluez.make
index 7838a096e0ed..d0c3a2f7399b 100644
--- a/rules/bluez.make
+++ b/rules/bluez.make
@@ -88,11 +88,11 @@ BLUEZ_CONF_OPT	:= $(CROSS_AUTOCONF_USR) \
 	--with-dbusconfdir=/usr/share \
 	--with-dbussystembusdir=/usr/share/dbus-1/system-services \
 	--with-dbussessionbusdir=/usr/share/dbus-1/services \
-	--with-zsh-completion-dir= \
+	--with-zsh-completion-dir=no \
 	--with-udevdir=/usr/lib/udev \
 	--with-systemdsystemunitdir=/usr/lib/systemd/system \
 	--with-systemduserunitdir=/usr/lib/systemd/user \
-	--with-phonebook=
+	--with-phonebook=dummy
 
 # ----------------------------------------------------------------------------
 # Target-Install
-- 
2.39.2

Re: [ptxdist] [APPLIED] bluez: cleanup default configuration values

[Michael Olbrich]

Thanks, applied as d15d8398f468218b122405f1937ff33c878e996a.

Michael

[sent from post-receive hook]

On Mon, 16 Sep 2024 16:34:12 +0200, Michael Tretter <m.tretter@pengutronix.de> wrote:
> Use the special value "no" to actually disable the zsh completions
> instead of using an empty path.
> 
> Use the value "dummy" for the phonebook, which bluez uses to internally
> to replace an empty string, and make the default explicit.
> 
> Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
> Message-Id: <20240912085725.1864129-1-m.tretter@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/rules/bluez.make b/rules/bluez.make
> index 7838a096e0ed..d0c3a2f7399b 100644
> --- a/rules/bluez.make
> +++ b/rules/bluez.make
> @@ -88,11 +88,11 @@ BLUEZ_CONF_OPT	:= $(CROSS_AUTOCONF_USR) \
>  	--with-dbusconfdir=/usr/share \
>  	--with-dbussystembusdir=/usr/share/dbus-1/system-services \
>  	--with-dbussessionbusdir=/usr/share/dbus-1/services \
> -	--with-zsh-completion-dir= \
> +	--with-zsh-completion-dir=no \
>  	--with-udevdir=/usr/lib/udev \
>  	--with-systemdsystemunitdir=/usr/lib/systemd/system \
>  	--with-systemduserunitdir=/usr/lib/systemd/user \
> -	--with-phonebook=
> +	--with-phonebook=dummy
>  
>  # ----------------------------------------------------------------------------
>  # Target-Install