From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 10 Sep 2024 12:55:19 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1snyWl-003847-1m for lore@lore.pengutronix.de; Tue, 10 Sep 2024 12:55:19 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1snyWk-0000LW-Ft; Tue, 10 Sep 2024 12:55:18 +0200 Received: from mail.thorsis.com ([217.92.40.78]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1snyWW-0000LH-FN; Tue, 10 Sep 2024 12:55:05 +0200 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id AF6A71483E65; Tue, 10 Sep 2024 12:55:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thorsis.com; s=dkim; t=1725965703; h=from:subject:date:message-id:to:cc:mime-version: content-transfer-encoding; bh=2Q44rUBMWPE9KCqUtrGMkc121N1tD00VTa/32/Hso5A=; b=aVWcKSu0arexQgXNmO2QeX9nkAsX16BEVpPr3eq6XyWtWlPomP1hxT3+XpD8GN4C0Yt+7s X+2eDSR5xssjPSotgIkWtIWYCQO8g18uVIbVBT4pEbWxXupRFu/lAdI3bTYc21hstqwDrH IYZXsk6zGMXDxpFYKC+BXYCuGbqwWMJlW/MgHnJ7GpRvM+zvtmA8XJay2RkQ8SUMpcHjz4 UP7SJgHiEjaEJxP4Y0YZMDFcJf5bB7zVp05xh73Iarp7sCQbTzo0QOxE3ISiEx62Z+VHVk ydXxkxrc5WtDB0gQhLV2GZQuHtDj4K0GDdlEi4VUd9rTpAW/1nZHT1qDwPzLIg== From: Alexander Dahl To: ptxdist@pengutronix.de Date: Tue, 10 Sep 2024 12:54:59 +0200 Message-Id: <20240910105459.3468520-1-ada@thorsis.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-3.2 required=4.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Subject: [ptxdist] [PATCH] util-linux: Enable libutil for pre glibc 2.34 toolchains X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: Michael Olbrich Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false Otherwise we get linker errors like this (e.g. with OSELAS.Toolchain-2020.08 coming with glibc 2.32): % p -v -j1 compile util-linux -------------------------- target: util-linux.compile -------------------------- ptxdist: executing: PATH=3D/home/adahl/Work/bsp/thorsis/ncl/tmp/platfor= m-ncl/sysroot-cross/usr/bin:/home/adahl/Work/bsp/thorsis/ncl/tmp/platform-n= cl/sysroot-cross/usr/sbin:/home/adahl/Work/bsp/thorsis/ncl/tmp/platform-ncl= /sysroot-host/usr/lib/wrapper:/home/adahl/Work/bsp/thorsis/ncl/tmp/platform= -ncl/sysroot-host/usr/bin:/home/adahl/Work/bsp/thorsis/ncl/tmp/platform-ncl= /sysroot-host/usr/sbin:/home/adahl/Work/bsp/thorsis/ncl/tmp/selected_toolch= ain:/usr/local/lib/ptxdist-2024.05.0/bin:/home/adahl/Work/bsp/thorsis/ncl/t= mp/platform-ncl/sysroot-host/usr/bin:/home/adahl/Work/bsp/thorsis/ncl/tmp/p= latform-ncl/sysroot-host/usr/sbin:/home/adahl/Work/bsp/thorsis/ncl/tmp/sele= cted_toolchain:/usr/local/lib/ptxdist-2024.04.0/bin:/home/adahl/bin:/home/a= dahl/.local/bin:/usr/local/bin:/usr/bin:/bin:/usr/games HTTPS_PROXY=3DPTXDI= ST-UNALLOWED-DOWNLOAD HTTP_PROXY=3DPTXDIST-UNALLOWED-DOWNLOAD https_proxy= =3DPTXDIST-UNALLOWED-DOWNLOAD http_proxy=3DPTXDIST-UNALLOWED-DOWNLOAD PKGCO= NFIG_WHITELIST_HOST=3D'' PKGCONFIG_WHITELIST_TARGET=3D'' PKGCONFIG_WHITELIS= T_SRC=3D'util-linux' SYSROOT=3D'/home/adahl/Work/bsp/thorsis/ncl/tmp/platfo= rm-ncl/sysroot-target' V=3D1 VERBOSE=3D1 LC_ALL=3D'C.utf8' KBUILD_BUILD_TIM= ESTAMP=3D2020-08-01T00:00:00+00:00 KBUILD_BUILD_USER=3Dptxdist KBUILD_BUILD= _HOST=3Dptxdist ninja -C /home/adahl/Work/bsp/thorsis/ncl/tmp/platform-ncl= /build-target/util-linux-2.40.2-build -v -j1 ninja: Entering directory `/home/adahl/Work/bsp/thorsis/ncl/tmp/platfor= m-ncl/build-target/util-linux-2.40.2-build' [1/75] arm-v5te-linux-gnueabi-gcc -o test_pty test_pty.p/lib_pty-sessi= on.c.o test_pty.p/lib_monotonic.c.o -Wl,--as-needed -Wl,--no-undefined -Wl,= --start-group lib/libcommon.a -lm -lrt -Wl,--end-group FAILED: test_pty arm-v5te-linux-gnueabi-gcc -o test_pty test_pty.p/lib_pty-session.c.o = test_pty.p/lib_monotonic.c.o -Wl,--as-needed -Wl,--no-undefined -Wl,--start= -group lib/libcommon.a -lm -lrt -Wl,--end-group /opt/OSELAS.Toolchain-2020.08.0/arm-v5te-linux-gnueabi/gcc-10.2.1-glibc= -2.32-binutils-2.35-kernel-5.8-sanitized/lib/gcc/arm-v5te-linux-gnueabi/10.= 2.1/../../../../arm-v5te-linux-gnueabi/bin/ld: test_pty.p/lib_pty-session.c= .o: in function `ul_pty_setup': platform-ncl/build-target/util-linux-2.40.2-build/../util-linux-2.40.2/= lib/pty-session.c:198: undefined reference to `openpty' /opt/OSELAS.Toolchain-2020.08.0/arm-v5te-linux-gnueabi/gcc-10.2.1-glibc= -2.32-binutils-2.35-kernel-5.8-sanitized/lib/gcc/arm-v5te-linux-gnueabi/10.= 2.1/../../../../arm-v5te-linux-gnueabi/bin/ld: platform-ncl/build-target/ut= il-linux-2.40.2-build/../util-linux-2.40.2/lib/pty-session.c:188: undefined= reference to `openpty' collect2: error: ld returned 1 exit status ninja: build stopped: subcommand failed. make: *** [/usr/local/lib/ptxdist-2024.05.0/rules/post/ptxd_make_world_= compile.make:20: /home/adahl/Work/bsp/thorsis/ncl/tmp/platform-ncl/state/ut= il-linux.compile] Error 1 Suggested-by: Michael Olbrich Fixes: 18c9c0f89c41 ("util-linux: switch to meson") Link: https://lore.ptxdist.org/ptxdist/ZuAYutgoVwik51tk@pengutronix.de/T/#u Signed-off-by: Alexander Dahl --- rules/util-linux.make | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rules/util-linux.make b/rules/util-linux.make index 62cd995a0..8cf82bd83 100644 --- a/rules/util-linux.make +++ b/rules/util-linux.make @@ -155,7 +155,7 @@ UTIL_LINUX_CONF_OPT :=3D \ -Dlibpcre2-posix=3Ddisabled \ -Dlibuser=3Ddisabled \ -Dlibutempter=3Ddisabled \ - -Dlibutil=3Ddisabled \ + -Dlibutil=3D$(call ptx/disen, PTXCONF_GLIBC_2_34)d \ -Dmagic=3Ddisabled \ -Dncurses=3D$(call ptx/endis, UTIL_LINUX_USES_NCURSES)d \ -Dncursesw=3D$(call ptx/endis, PTXCONF_UTIL_LINUX_USES_NCURSESW)d \ base-commit: e16ba2b3690107c5b42109f6808c49912049be22 --=20 2.39.2