From mboxrd@z Thu Jan  1 00:00:00 1970
Delivery-date: Mon, 05 Aug 2024 08:54:10 +0200
Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104])
	by lore.white.stw.pengutronix.de with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <ptxdist-bounces+lore=lore.pengutronix.de@pengutronix.de>)
	id 1sarbe-006P9V-0O
	for lore@lore.pengutronix.de;
	Mon, 05 Aug 2024 08:54:10 +0200
Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de)
	by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92)
	(envelope-from <ptxdist-bounces@pengutronix.de>)
	id 1sarbd-0007wa-Na; Mon, 05 Aug 2024 08:54:09 +0200
Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2])
 by metis.whiteo.stw.pengutronix.de with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92)
 (envelope-from <mol@pengutronix.de>)
 id 1sarXI-0003kF-KH; Mon, 05 Aug 2024 08:49:40 +0200
Received: from [2a0a:edc0:0:1101:1d::54] (helo=dude05.red.stw.pengutronix.de)
 by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2)
 (envelope-from <mol@pengutronix.de>)
 id 1sarXH-004eB9-VO; Mon, 05 Aug 2024 08:49:39 +0200
Received: from mol by dude05.red.stw.pengutronix.de with local (Exim 4.96)
 (envelope-from <mol@pengutronix.de>) id 1sarXH-003jbA-2z;
 Mon, 05 Aug 2024 08:49:39 +0200
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Date: Mon,  5 Aug 2024 08:49:39 +0200
Message-Id: <20240805064939.890257-1-m.olbrich@pengutronix.de>
X-Mailer: git-send-email 2.39.2
In-Reply-To: <20240717213557.2353045-1-christian.melki@t2data.com>
References: <20240717213557.2353045-1-christian.melki@t2data.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: Re: [ptxdist] [APPLIED] libffi: Adjust build options.
X-BeenThere: ptxdist@pengutronix.de
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <https://metis.pengutronix.de/mailman/options/ptxdist>,
 <mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <https://metis.pengutronix.de/mailman/private/ptxdist/>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <https://metis.pengutronix.de/mailman/listinfo/ptxdist>,
 <mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Reply-To: ptxdist@pengutronix.de
Cc: Christian Melki <christian.melki@t2data.com>
Sender: "ptxdist" <ptxdist-bounces@pengutronix.de>
X-SA-Exim-Connect-IP: 127.0.0.1
X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de
X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false

Thanks, applied as df21e0052277c9c2ae42f7c03fb36affa0e8088e.

Michael

[sent from post-receive hook]

On Mon, 05 Aug 2024 08:49:39 +0200, Christian Melki <christian.melki@t2data.com> wrote:
> When upgrading automake, libffi failed to build due to
> a makefile error. The error is triggered when using options
> we don't really need. Circumvent the issue by changing options
> and also improve a few others.
> 
> * Rearrange one option.
> 
> * Disable internal builddir in the srcdir and disable using gcc
> as discovery for multidir arch directories.
> 
> * Force static trampolines. Dynamic ones are a security issue.
> Now this might break some programs and probably make debugging
> using gobject introspection difficult, but otoh, it stops usage
> of self modifying code.
> 
> * Keep patches. I guess they can both go away, but I don't
> see much harm in continuing to use them.
> 
> Signed-off-by: Christian Melki <christian.melki@t2data.com>
> Message-Id: <20240717213557.2353045-1-christian.melki@t2data.com>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/rules/libffi.make b/rules/libffi.make
> index 4ccc437d5e99..f9a6bd397045 100644
> --- a/rules/libffi.make
> +++ b/rules/libffi.make
> @@ -33,14 +33,17 @@ LIBFFI_LICENSE_FILES	:= \
>  LIBFFI_CONF_TOOL := autoconf
>  LIBFFI_CONF_OPT := \
>  	$(CROSS_AUTOCONF_USR) \
> +	--disable-builddir \
>  	--disable-static \
>  	--enable-portable-binary \
>  	--disable-pax_emutramp \
> -	--disable-debug \
>  	--disable-docs \
> +	--disable-debug \
>  	--enable-structs \
>  	--enable-raw-api \
> +	--enable-exec-static-tramp \
>  	--disable-purify-safety \
> +	--disable-multi-os-directory \
>  	--without-gcc-arch
>  
>  # ----------------------------------------------------------------------------