From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 02 Aug 2024 12:25:58 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1sZpTy-005RAf-1g for lore@lore.pengutronix.de; Fri, 02 Aug 2024 12:25:58 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1sZpTx-0004z1-D2; Fri, 02 Aug 2024 12:25:57 +0200 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sZpTX-0004yD-8n; Fri, 02 Aug 2024 12:25:31 +0200 Received: from [2a0a:edc0:0:1101:1d::ac] (helo=dude04.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sZpTW-003z7C-Rj; Fri, 02 Aug 2024 12:25:30 +0200 Received: from rhi by dude04.red.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1sZpTW-005vBC-2Z; Fri, 02 Aug 2024 12:25:30 +0200 From: Roland Hieber To: ptxdist@pengutronix.de Date: Fri, 2 Aug 2024 12:25:28 +0200 Message-Id: <20240802102529.1411407-1-rhi@pengutronix.de> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Mail-Followup-To: Roland Hieber , ptxdist@pengutronix.de Content-Transfer-Encoding: 8bit Subject: [ptxdist] [PATCH 1/2] barebox: remove superfluous ptxd_source_kconfig calls X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: Roland Hieber Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false These calls make the PTXCONF_* variables from the ptxconfig and the platformconfig available in the local shell environment, but no PTXCONF_ variable is used later in the shell call. This is probably a left-over from when the defaultenv preparation was made layer-aware in commit 41cb4d9f9287d85ae11b (2018-07-24, Michael Olbrich: "barebox: support layers with BAREBOX_EXTRA_ENV_PATH"). Signed-off-by: Roland Hieber --- rules/barebox.make | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/rules/barebox.make b/rules/barebox.make index c0d9c5744e4a..bcb96e607b91 100644 --- a/rules/barebox.make +++ b/rules/barebox.make @@ -87,9 +87,7 @@ endif ifdef PTXCONF_BAREBOX_EXTRA_ENV @rm -rf $(BAREBOX_BUILD_DIR)/.ptxdist-defaultenv - @ptxd_source_kconfig "${PTXDIST_PTXCONFIG}" && \ - ptxd_source_kconfig "${PTXDIST_PLATFORMCONFIG}" && \ - $(foreach path, $(BAREBOX_EXTRA_ENV_PATH), \ + @$(foreach path, $(BAREBOX_EXTRA_ENV_PATH), \ if [ -d "$(path)" ]; then \ ptxd_filter_dir "$(path)" \ $(BAREBOX_BUILD_DIR)/.ptxdist-defaultenv; \ -- 2.39.2