mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Roland Hieber <rhi@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Roland Hieber <rhi@pengutronix.de>
Subject: [ptxdist] [PATCH 1/2] barebox: remove superfluous ptxd_source_kconfig calls
Date: Fri,  2 Aug 2024 12:25:28 +0200	[thread overview]
Message-ID: <20240802102529.1411407-1-rhi@pengutronix.de> (raw)

These calls make the PTXCONF_* variables from the ptxconfig and the
platformconfig available in the local shell environment, but no PTXCONF_
variable is used later in the shell call. This is probably a left-over
from when the defaultenv preparation was made layer-aware in commit
41cb4d9f9287d85ae11b (2018-07-24, Michael Olbrich: "barebox: support
layers with BAREBOX_EXTRA_ENV_PATH").

Signed-off-by: Roland Hieber <rhi@pengutronix.de>
---
 rules/barebox.make | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/rules/barebox.make b/rules/barebox.make
index c0d9c5744e4a..bcb96e607b91 100644
--- a/rules/barebox.make
+++ b/rules/barebox.make
@@ -87,9 +87,7 @@ endif
 
 ifdef PTXCONF_BAREBOX_EXTRA_ENV
 	@rm -rf $(BAREBOX_BUILD_DIR)/.ptxdist-defaultenv
-	@ptxd_source_kconfig "${PTXDIST_PTXCONFIG}" && \
-	ptxd_source_kconfig "${PTXDIST_PLATFORMCONFIG}" && \
-	$(foreach path, $(BAREBOX_EXTRA_ENV_PATH), \
+	@$(foreach path, $(BAREBOX_EXTRA_ENV_PATH), \
 		if [ -d "$(path)" ]; then \
 			ptxd_filter_dir "$(path)" \
 			$(BAREBOX_BUILD_DIR)/.ptxdist-defaultenv; \
-- 
2.39.2




             reply	other threads:[~2024-08-02 10:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-02 10:25 Roland Hieber [this message]
2024-08-02 10:25 ` [ptxdist] [PATCH 2/2] templates: barebox: use ptx/image-install Roland Hieber
2024-09-12 12:11   ` [ptxdist] [APPLIED] " Michael Olbrich
2024-08-08  9:36 ` [ptxdist] [PATCH 3/2] templates: kernel: use ptx/image-install and fix clean stage Roland Hieber
2024-09-12 12:11   ` [ptxdist] [APPLIED] " Michael Olbrich
2024-08-08 14:14 ` [ptxdist] [PATCH 1/2] barebox: remove superfluous ptxd_source_kconfig calls Michael Olbrich
2024-08-26 12:09   ` Roland Hieber
2024-09-06 14:03 ` Michael Olbrich
2024-09-06 14:05   ` Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240802102529.1411407-1-rhi@pengutronix.de \
    --to=rhi@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox