mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Christian Melki <christian.melki@t2data.com>
To: ptxdist@pengutronix.de
Subject: [ptxdist] [PATCH 1/2] libffi: Adjust build options.
Date: Wed, 17 Jul 2024 23:35:56 +0200	[thread overview]
Message-ID: <20240717213557.2353045-1-christian.melki@t2data.com> (raw)

When upgrading automake, libffi failed to build due to
a makefile error. The error is triggered when using options
we don't really need. Circumvent the issue by changing options
and also improve a few others.

* Rearrange one option.

* Disable internal builddir in the srcdir and disable using gcc
as discovery for multidir arch directories.

* Force static trampolines. Dynamic ones are a security issue.
Now this might break some programs and probably make debugging
using gobject introspection difficult, but otoh, it stops usage
of self modifying code.

* Keep patches. I guess they can both go away, but I don't
see much harm in continuing to use them.

Signed-off-by: Christian Melki <christian.melki@t2data.com>
---
 rules/libffi.make | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/rules/libffi.make b/rules/libffi.make
index 4ccc437d5..f9a6bd397 100644
--- a/rules/libffi.make
+++ b/rules/libffi.make
@@ -33,14 +33,17 @@ LIBFFI_LICENSE_FILES	:= \
 LIBFFI_CONF_TOOL := autoconf
 LIBFFI_CONF_OPT := \
 	$(CROSS_AUTOCONF_USR) \
+	--disable-builddir \
 	--disable-static \
 	--enable-portable-binary \
 	--disable-pax_emutramp \
-	--disable-debug \
 	--disable-docs \
+	--disable-debug \
 	--enable-structs \
 	--enable-raw-api \
+	--enable-exec-static-tramp \
 	--disable-purify-safety \
+	--disable-multi-os-directory \
 	--without-gcc-arch
 
 # ----------------------------------------------------------------------------
-- 
2.34.1




             reply	other threads:[~2024-07-17 21:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-17 21:35 Christian Melki [this message]
2024-07-17 21:35 ` [ptxdist] [PATCH 2/2] host-libffi: Follow target libffi Christian Melki
2024-08-05  6:49   ` [ptxdist] [APPLIED] " Michael Olbrich
2024-08-05  6:49 ` [ptxdist] [APPLIED] libffi: Adjust build options Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240717213557.2353045-1-christian.melki@t2data.com \
    --to=christian.melki@t2data.com \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox