[ptxdist] [PATCH] ptxd_make_get: verbose on wget

[ptxdist] [PATCH] ptxd_make_get: verbose on wget

[Bruno Thomsen]

Change wget progress to none when verbose is chosen,
so it's possible to see download URLs.

Tested on GNU Wget2 2.1.0 (Fedora 40).

Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
---
Indentation just follow the style around existing if statement.

 scripts/lib/ptxd_make_get.sh | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/scripts/lib/ptxd_make_get.sh b/scripts/lib/ptxd_make_get.sh
index 4951abe5a..5e2152b36 100644
--- a/scripts/lib/ptxd_make_get.sh
+++ b/scripts/lib/ptxd_make_get.sh
@@ -94,7 +94,9 @@ ptxd_make_get_http() {
 	return
     elif [ ! -e "${path}" ]; then
 	temp_file="$(mktemp "${path}.XXXXXXXXXX")" || ptxd_bailout "failed to create tempfile"
-	if [ -n "${PTXDIST_QUIET}" ]; then
+	if [ "${PTXDIST_VERBOSE}" == "1" ]; then
+	    progress=none
+	elif [ -n "${PTXDIST_QUIET}" ]; then
 	    progress=dot
 	else
 	    progress=bar:force

base-commit: 8c653b78e0052755fa9eca1579199568d7cf4e4a
-- 
2.45.2

Re: [ptxdist] [PATCH] ptxd_make_get: verbose on wget

[Michael Olbrich]

On Tue, Jul 16, 2024 at 09:59:44PM +0200, Bruno Thomsen wrote:
> Change wget progress to none when verbose is chosen,
> so it's possible to see download URLs.
> 
> Tested on GNU Wget2 2.1.0 (Fedora 40).
> 
> Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
> ---
> Indentation just follow the style around existing if statement.
> 
>  scripts/lib/ptxd_make_get.sh | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/scripts/lib/ptxd_make_get.sh b/scripts/lib/ptxd_make_get.sh
> index 4951abe5a..5e2152b36 100644
> --- a/scripts/lib/ptxd_make_get.sh
> +++ b/scripts/lib/ptxd_make_get.sh
> @@ -94,7 +94,9 @@ ptxd_make_get_http() {
>  	return
>      elif [ ! -e "${path}" ]; then
>  	temp_file="$(mktemp "${path}.XXXXXXXXXX")" || ptxd_bailout "failed to create tempfile"
> -	if [ -n "${PTXDIST_QUIET}" ]; then
> +	if [ "${PTXDIST_VERBOSE}" == "1" ]; then
> +	    progress=none

That is not supported by wget 1.x so this needs a version check.

Michael

> +	elif [ -n "${PTXDIST_QUIET}" ]; then
>  	    progress=dot
>  	else
>  	    progress=bar:force
> 
> base-commit: 8c653b78e0052755fa9eca1579199568d7cf4e4a
> -- 
> 2.45.2
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |