* [ptxdist] [PATCH] ptxd_make_get: verbose on wget
@ 2024-07-16 19:59 Bruno Thomsen
2024-08-02 8:05 ` Michael Olbrich
0 siblings, 1 reply; 2+ messages in thread
From: Bruno Thomsen @ 2024-07-16 19:59 UTC (permalink / raw)
To: ptxdist; +Cc: Bruno Thomsen
Change wget progress to none when verbose is chosen,
so it's possible to see download URLs.
Tested on GNU Wget2 2.1.0 (Fedora 40).
Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
---
Indentation just follow the style around existing if statement.
scripts/lib/ptxd_make_get.sh | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/scripts/lib/ptxd_make_get.sh b/scripts/lib/ptxd_make_get.sh
index 4951abe5a..5e2152b36 100644
--- a/scripts/lib/ptxd_make_get.sh
+++ b/scripts/lib/ptxd_make_get.sh
@@ -94,7 +94,9 @@ ptxd_make_get_http() {
return
elif [ ! -e "${path}" ]; then
temp_file="$(mktemp "${path}.XXXXXXXXXX")" || ptxd_bailout "failed to create tempfile"
- if [ -n "${PTXDIST_QUIET}" ]; then
+ if [ "${PTXDIST_VERBOSE}" == "1" ]; then
+ progress=none
+ elif [ -n "${PTXDIST_QUIET}" ]; then
progress=dot
else
progress=bar:force
base-commit: 8c653b78e0052755fa9eca1579199568d7cf4e4a
--
2.45.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [ptxdist] [PATCH] ptxd_make_get: verbose on wget
2024-07-16 19:59 [ptxdist] [PATCH] ptxd_make_get: verbose on wget Bruno Thomsen
@ 2024-08-02 8:05 ` Michael Olbrich
0 siblings, 0 replies; 2+ messages in thread
From: Michael Olbrich @ 2024-08-02 8:05 UTC (permalink / raw)
To: Bruno Thomsen; +Cc: ptxdist
On Tue, Jul 16, 2024 at 09:59:44PM +0200, Bruno Thomsen wrote:
> Change wget progress to none when verbose is chosen,
> so it's possible to see download URLs.
>
> Tested on GNU Wget2 2.1.0 (Fedora 40).
>
> Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
> ---
> Indentation just follow the style around existing if statement.
>
> scripts/lib/ptxd_make_get.sh | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/lib/ptxd_make_get.sh b/scripts/lib/ptxd_make_get.sh
> index 4951abe5a..5e2152b36 100644
> --- a/scripts/lib/ptxd_make_get.sh
> +++ b/scripts/lib/ptxd_make_get.sh
> @@ -94,7 +94,9 @@ ptxd_make_get_http() {
> return
> elif [ ! -e "${path}" ]; then
> temp_file="$(mktemp "${path}.XXXXXXXXXX")" || ptxd_bailout "failed to create tempfile"
> - if [ -n "${PTXDIST_QUIET}" ]; then
> + if [ "${PTXDIST_VERBOSE}" == "1" ]; then
> + progress=none
That is not supported by wget 1.x so this needs a version check.
Michael
> + elif [ -n "${PTXDIST_QUIET}" ]; then
> progress=dot
> else
> progress=bar:force
>
> base-commit: 8c653b78e0052755fa9eca1579199568d7cf4e4a
> --
> 2.45.2
>
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-08-02 8:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-16 19:59 [ptxdist] [PATCH] ptxd_make_get: verbose on wget Bruno Thomsen
2024-08-02 8:05 ` Michael Olbrich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox