From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Wed, 12 Jun 2024 14:33:35 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1sHNAV-004o74-25 for lore@lore.pengutronix.de; Wed, 12 Jun 2024 14:33:35 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1sHNAU-0004d4-Tc; Wed, 12 Jun 2024 14:33:34 +0200 Received: from mail.thorsis.com ([217.92.40.78]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sHNA4-0004cr-9g; Wed, 12 Jun 2024 14:33:08 +0200 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id F3E8214865E4; Wed, 12 Jun 2024 14:33:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thorsis.com; s=dkim; t=1718195587; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=6BJdL9BmODUMEIB8QwJa0drqoKe0IBstVU4J2Y7LY+c=; b=dk1ryhYb130v4+/bkr+glKFIjUW2zdXAcbjjYxBatREQDioVdGXApvxwS5r2bt7Xd86wEy nTWU7rH6Av+vAJnPFq2Ie3/C9jLcBxnfJQTADu1fC2RGB0OMUwUUIbUgABk4FtZQOh96aD 9dNK4MeySsKc1y0Dv3aep4q/o6RC5XfebmQQNkTauKJCiwu+YSKm3X7Q9bCM46cS3b1K1G 4gWLrAsRMrWhg6TTBgf6f/5b8R5FxA5XIBUwgMNedQ+KB5MnF/ZoVwjR8DKhrATHZVymDT Peo66v5X73V6r0WoPIBPuFwrVOmfAOqQryOVdyAUcjzUA9uXKGQTxryvqkuGnA== Date: Wed, 12 Jun 2024 14:32:59 +0200 From: Alexander Dahl To: Lucas Stach Message-ID: <20240612-undead-remover-b8858c6675ad@thorsis.com> Mail-Followup-To: Lucas Stach , ptxdist@pengutronix.de References: <20240514203552.1297323-1-l.stach@pengutronix.de> <20240514203552.1297323-8-l.stach@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240514203552.1297323-8-l.stach@pengutronix.de> User-Agent: Mutt/2.2.12 (2023-09-09) X-Last-TLS-Session-Version: TLSv1.3 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-2.8 required=4.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.2 Subject: Re: [ptxdist] [PATCH 07/20] figlet: replace URL with HTTPS X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false Hei hei, sorry for being late to the party, but we just discussed this in IRC … Am Tue, May 14, 2024 at 10:35:39PM +0200 schrieb Lucas Stach: > As the figlet page only provides FTP downloads, point the download > URL to the github repository of the maintainer, which is also linked > from the homepage. > > Signed-off-by: Lucas Stach > --- > rules/figlet.make | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/rules/figlet.make b/rules/figlet.make > index 3dad77154430..c6d2fb38ea06 100644 > --- a/rules/figlet.make > +++ b/rules/figlet.make > @@ -20,7 +20,7 @@ FIGLET_VERSION := 2.2.5 > FIGLET_MD5 := d88cb33a14f1469fff975d021ae2858e > FIGLET := figlet-$(FIGLET_VERSION) > FIGLET_SUFFIX := tar.gz > -FIGLET_URL := ftp://ftp.figlet.org/pub/figlet/program/unix/$(FIGLET).$(FIGLET_SUFFIX) > +FIGLET_URL := https://github.com/cmatsuoka/figlet/archive/refs/tags/$(FIGLET_VERSION).$(FIGLET_SUFFIX) This is replacing a probably handcrafted tarball from 10+ years ago with a machine generated tarball from today. Although the content looks similar, the md5sum is not the same. What about using this instead? http://ftp.figlet.org/pub/figlet/program/unix/figlet-2.2.5.tar.gz Greets Alex > FIGLET_SOURCE := $(SRCDIR)/$(FIGLET).$(FIGLET_SUFFIX) > FIGLET_DIR := $(BUILDDIR)/$(FIGLET) > FIGLET_LICENSE := BSD-3-clause > -- > 2.39.2 > >