Re: [ptxdist] [APPLIED] ptxd_make_world_lint: check for usage of deprecated FTP protocol

[Michael Olbrich <m.olbrich@pengutronix.de>]

Thanks, applied as 25569bfbd9aa26d3f5eb7635ae421c216211511b.

Michael

[sent from post-receive hook]

On Mon, 10 Jun 2024 21:41:33 +0200, Lucas Stach <l.stach@pengutronix.de> wrote:
> FTP is on its way out, so it should not be used in package URLs
> anymore. Add a lint check to ensure that.
> 
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> Message-Id: <20240527201347.673604-6-l.stach@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/scripts/lib/ptxd_make_world_lint.sh b/scripts/lib/ptxd_make_world_lint.sh
> index 01a35d4801b8..42785f186d77 100644
> --- a/scripts/lib/ptxd_make_world_lint.sh
> +++ b/scripts/lib/ptxd_make_world_lint.sh
> @@ -281,6 +281,23 @@ ptxd_make_world_lint_credits() {
>  export -f ptxd_make_world_lint_credits
>  PTXDIST_LINT_COMMANDS="${PTXDIST_LINT_COMMANDS} credits"
>  
> +ptxd_make_world_lint_ftp() {
> +    local filefd file
> +
> +    echo "Checking for deprecated FTP protocol use in package URL ..."
> +
> +    exec {filefd}< <(ptxd_make_world_lint_makefiles)
> +    while read file <&${filefd}; do
> +	if grep -q "URL.*ftp://" "${file}"; then
> +	    ptxd_lint_error "'$(ptxd_print_path "${file}")' contains deprecated FTP URL."
> +	fi
> +    done
> +    exec {filefd}<&-
> +    echo
> +}
> +export -f ptxd_make_world_lint_ftp
> +PTXDIST_LINT_COMMANDS="${PTXDIST_LINT_COMMANDS} ftp"
> +
>  unset ptxd_make_world_lint_cross_whitelist
>  # we don't care about the initmethod
>  ptxd_make_world_lint_cross_whitelist+="INITMETHOD_BBINIT INITMETHOD_SYSTEMD "