Re: [ptxdist] [APPLIED] bash: allow installation of /usr/bin/sh symlink to be chosen manually

[Michael Olbrich <m.olbrich@pengutronix.de>]

Thanks, applied as 2b2bc8abf7ef1d4000c02a18b0a573948f6f5138.

Michael

[sent from post-receive hook]

On Fri, 31 May 2024 08:08:29 +0200, Ian Abbott <abbotti@mev.co.uk> wrote:
> It is possible for any of BusyBox, Dash, or Bash to install the
> /usr/bin/sh symbolic link.  Only allow BASH_SH to be enabled if the
> symbolic link is not being installed by either BusyBox or Dash (unless
> overridden by ALLYES).  Default to enabled if the link is not being
> installed by BusyBox or Dash.  Also allow it to be manually disabled.
> 
> Rationale: It is common for Bash to be installed as an interactive login
> shell, but to use something lighter and faster for non-interactive use.
> Shell scripts typically use /bin/sh as the interpreter selected by the
> "shebang" line.
> 
> Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
> Message-Id: <20240513132247.25521-3-abbotti@mev.co.uk>
> [mol: simplify 'default']
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/rules/bash.in b/rules/bash.in
> index 3b3dd845d4e2..0f8f33f82499 100644
> --- a/rules/bash.in
> +++ b/rules/bash.in
> @@ -262,8 +262,20 @@ config BASH_CURSES
>  	bool
>  	prompt "Use libcurses instead of libtermcap"
>  
> +comment "BusyBox sh is selected"
> +	depends on BUSYBOX && !BUSYBOX_SH_IS_NONE
> +
> +comment "Dash sh is selected"
> +	depends on DASH_LINK_SH
> +
>  config BASH_SH
>  	bool
> -	default BUSYBOX = n || BUSYBOX_SH_IS_NONE
> +	depends on (!BUSYBOX || BUSYBOX_SH_IS_NONE) && !DASH_LINK_SH || ALLYES
> +	default y
> +	prompt "link to /bin/sh"
> +	help
> +	  Create a link symbolic link "/usr/bin/sh" ("/bin/sh") to
> +	  "bash".  Select this to use bash as the interpreter for Bourne
> +	  shell scripts using the canonical "#!/bin/sh" shebang line.
>  
>  endif