mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: r.czerwinski@pengutronix.de
To: ptxdist@pengutronix.de
Cc: Rouven Czerwinski <r.czerwinski@pengutronix.de>
Subject: [ptxdist] [PATCH v2] rauc: optional rauc-mark-good.service installation
Date: Tue, 28 May 2024 16:55:46 +0200	[thread overview]
Message-ID: <20240528145545.431218-2-r.czerwinski@pengutronix.de> (raw)

From: Rouven Czerwinski <r.czerwinski@pengutronix.de>

Make the installation and enablement of the rauc-mark-good.service
optional. This is useful for BSPs which have the application indicate if
startup was successful instead of indicating successful startup using the
rauc-mark-good-service.

Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
---
v2:
- fix typos
- properly name service in KConfig entry
 rules/rauc.in   | 10 ++++++++++
 rules/rauc.make |  2 ++
 2 files changed, 12 insertions(+)

diff --git a/rules/rauc.in b/rules/rauc.in
index ee9c3f955..68fa59b31 100644
--- a/rules/rauc.in
+++ b/rules/rauc.in
@@ -46,6 +46,16 @@ config RAUC_SERVICE
 	  that communicate with each other via D-Bus interface.
 	  Only deactivate this if you have a system that does not provide D-Bus!
 
+config RAUC_MARK_GOOD
+	bool
+	prompt "Enable systemd rauc-mark-good.service"
+	default y
+	help
+	  Installs and enables the default rauc-mark-good.service shipped with rauc.
+	  The rauc-mark-good.service runs when the systemd has successfully started
+	  up, which is not desirable if the application indicates the succesful
+	  startup.
+
 config RAUC_NETWORK
 	bool
 	prompt "Enable network support"
diff --git a/rules/rauc.make b/rules/rauc.make
index 38577f94d..7aed77e89 100644
--- a/rules/rauc.make
+++ b/rules/rauc.make
@@ -95,10 +95,12 @@ ifdef PTXCONF_INITMETHOD_SYSTEMD
 	@$(call install_alternative, rauc, 0, 0, 0644, \
 		/usr/lib/systemd/system/rauc.service)
 
+ifdef PTXCONF_RAUC_MARK_GOOD
 	@$(call install_alternative, rauc, 0, 0, 0644, \
 		/usr/lib/systemd/system/rauc-mark-good.service)
 	@$(call install_link, rauc, ../rauc-mark-good.service, \
 		/usr/lib/systemd/system/multi-user.target.wants/rauc-mark-good.service)
+endif
 else
 	@$(call install_copy, rauc, 0, 0, 0755, -, \
 		/usr/libexec/rauc-service.sh)
-- 
2.44.1




             reply	other threads:[~2024-05-28 14:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-28 14:55 r.czerwinski [this message]
2024-05-31  7:37 ` Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240528145545.431218-2-r.czerwinski@pengutronix.de \
    --to=r.czerwinski@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox