mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Lucas Stach <l.stach@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: [ptxdist] [PATCH 20/20] ptxd_make_get: remove FTP support
Date: Tue, 14 May 2024 22:35:52 +0200	[thread overview]
Message-ID: <20240514203552.1297323-21-l.stach@pengutronix.de> (raw)
In-Reply-To: <20240514203552.1297323-1-l.stach@pengutronix.de>

wget2 as an (almost) drop-in replacement to wget doesn't support the
FTP(S) protocol. Instead of trying to fix FTP downloads via other
tools simply remove the support, as it's not really needed anymore
due to available alternatives.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 scripts/lib/ptxd_make_get.sh | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/scripts/lib/ptxd_make_get.sh b/scripts/lib/ptxd_make_get.sh
index c06257ee6ebb..615809125932 100644
--- a/scripts/lib/ptxd_make_get.sh
+++ b/scripts/lib/ptxd_make_get.sh
@@ -75,7 +75,6 @@ ptxd_make_get_http() {
 	echo "Checking URL '${url}'..."
 	temp_header="$(mktemp "${PTXDIST_TEMPDIR}/urlcheck.XXXXXX")" || ptxd_bailout "failed to create tempfile"
 	curl \
-	--ftp-pasv \
 	--connect-timeout 30 \
 	--retry 5 \
 	--user-agent "PTXdist ${PTXDIST_VERSION_FULL}" \
@@ -101,7 +100,6 @@ ptxd_make_get_http() {
 	    progress=bar:force
 	fi
 	wget \
-	--passive-ftp \
 	--progress="${progress}" \
 	--timeout=30 \
 	--tries=5 \
@@ -526,7 +524,7 @@ ptxd_make_get() {
 	    ptxd_make_get_download_permitted &&
 	    ptxd_make_get_svn && return
 	    ;;
-	http://*|https://*|ftp://*)
+	http://*|https://*)
 	    ptxd_make_get_download_permitted &&
 	    ptxd_make_get_http && return
 	    ;;
-- 
2.39.2




  parent reply	other threads:[~2024-05-14 20:43 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-14 20:35 [ptxdist] [PATCH 00/20] " Lucas Stach
2024-05-14 20:35 ` [ptxdist] [PATCH 01/20] alsa-lib: remove FTP URL Lucas Stach
2024-05-21  9:59   ` [ptxdist] [APPLIED] " Michael Olbrich
2024-05-14 20:35 ` [ptxdist] [PATCH 02/20] alsa-utils: " Lucas Stach
2024-05-21  9:59   ` [ptxdist] [APPLIED] " Michael Olbrich
2024-05-14 20:35 ` [ptxdist] [PATCH 03/20] ckermit: replace download URL with HTTP Lucas Stach
2024-05-21  9:59   ` [ptxdist] [APPLIED] " Michael Olbrich
2024-05-14 20:35 ` [ptxdist] [PATCH 04/20] dialog: remove FTP URL Lucas Stach
2024-05-21  9:59   ` [ptxdist] [APPLIED] " Michael Olbrich
2024-05-14 20:35 ` [ptxdist] [PATCH 05/20] efax: replace download URL with HTTPS Lucas Stach
2024-05-15  6:25   ` Michael Olbrich
2024-05-14 20:35 ` [ptxdist] [PATCH 06/20] fftw: remove FTP URL Lucas Stach
2024-05-21  9:59   ` [ptxdist] [APPLIED] " Michael Olbrich
2024-05-14 20:35 ` [ptxdist] [PATCH 07/20] figlet: replace URL with HTTPS Lucas Stach
2024-05-21  9:59   ` [ptxdist] [APPLIED] " Michael Olbrich
2024-06-12 12:32   ` [ptxdist] [PATCH 07/20] " Alexander Dahl
2024-06-13  8:05     ` Michael Olbrich
2024-05-14 20:35 ` [ptxdist] [PATCH 08/20] gdb: remove FTP URL Lucas Stach
2024-05-15  5:52   ` Alexander Dahl
2024-05-15  6:27   ` Michael Olbrich
2024-05-14 20:35 ` [ptxdist] [PATCH 09/20] gdbserver: " Lucas Stach
2024-05-15  5:53   ` Alexander Dahl
2024-05-15  6:27   ` Michael Olbrich
2024-05-14 20:35 ` [ptxdist] [PATCH 10/20] glu: replace download URL with HTTPS Lucas Stach
2024-05-21  9:59   ` [ptxdist] [APPLIED] " Michael Olbrich
2024-05-14 20:35 ` [ptxdist] [PATCH 11/20] gnupg: remove FTP URL Lucas Stach
2024-05-21  9:59   ` [ptxdist] [APPLIED] " Michael Olbrich
2024-05-14 20:35 ` [ptxdist] [PATCH 12/20] libffi: " Lucas Stach
2024-05-21  9:59   ` [ptxdist] [APPLIED] " Michael Olbrich
2024-05-14 20:35 ` [ptxdist] [PATCH 13/20] libgpg-error: " Lucas Stach
2024-05-21  9:59   ` [ptxdist] [APPLIED] " Michael Olbrich
2024-05-14 20:35 ` [ptxdist] [PATCH 14/20] libksba: " Lucas Stach
2024-05-21  9:59   ` [ptxdist] [APPLIED] " Michael Olbrich
2024-05-14 20:35 ` [ptxdist] [PATCH 15/20] mesa-demos: replace download URL with HTTPS Lucas Stach
2024-05-21  9:59   ` [ptxdist] [APPLIED] " Michael Olbrich
2024-05-14 20:35 ` [ptxdist] [PATCH 16/20] netkit-ftp: remove FTP URL Lucas Stach
2024-05-21  9:59   ` [ptxdist] [APPLIED] " Michael Olbrich
2024-05-14 20:35 ` [ptxdist] [PATCH 17/20] npth: " Lucas Stach
2024-05-21  9:59   ` [ptxdist] [APPLIED] " Michael Olbrich
2024-05-14 20:35 ` [ptxdist] [PATCH 18/20] nvmetcli: version bump 0.7 -> 0.8 Lucas Stach
2024-05-21  9:59   ` [ptxdist] [APPLIED] " Michael Olbrich
2024-05-14 20:35 ` [ptxdist] [PATCH 19/20] proftpd: move to staging Lucas Stach
2024-05-21  9:59   ` [ptxdist] [APPLIED] " Michael Olbrich
2024-05-14 20:35 ` Lucas Stach [this message]
2024-05-15  6:38   ` [ptxdist] [PATCH 20/20] ptxd_make_get: remove FTP support Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240514203552.1297323-21-l.stach@pengutronix.de \
    --to=l.stach@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox