From: Ian Abbott <abbotti@mev.co.uk>
To: ptxdist@pengutronix.de
Cc: Ian Abbott <abbotti@mev.co.uk>
Subject: [ptxdist] [PATCH 2/2] bash: allow installation of /usr/bin/sh symlink to be chosen manually
Date: Mon, 13 May 2024 13:55:06 +0100 [thread overview]
Message-ID: <20240513132247.25521-3-abbotti@mev.co.uk> (raw)
In-Reply-To: <20240513132247.25521-1-abbotti@mev.co.uk>
It is possible for any of BusyBox, Dash, or Bash to install the
/usr/bin/sh symbolic link. Only allow BASH_SH to be enabled if the
symbolic link is not being installed by either BusyBox or Dash (unless
overridden by ALLYES). Default to enabled if the link is not being
installed by BusyBox or Dash. Also allow it to be manually disabled.
Rationale: It is common for Bash to be installed as an interactive login
shell, but to use something lighter and faster for non-interactive use.
Shell scripts typically use /bin/sh as the interpreter selected by the
"shebang" line.
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
---
rules/bash.in | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/rules/bash.in b/rules/bash.in
index 3b3dd845d..5276df8d1 100644
--- a/rules/bash.in
+++ b/rules/bash.in
@@ -262,8 +262,20 @@ config BASH_CURSES
bool
prompt "Use libcurses instead of libtermcap"
+comment "BusyBox sh is selected"
+ depends on BUSYBOX && !BUSYBOX_SH_IS_NONE
+
+comment "Dash sh is selected"
+ depends on DASH_LINK_SH
+
config BASH_SH
bool
- default BUSYBOX = n || BUSYBOX_SH_IS_NONE
+ depends on (!BUSYBOX || BUSYBOX_SH_IS_NONE) && !DASH_LINK_SH || ALLYES
+ default (!BUSYBOX || BUSYBOX_SH_IS_NONE) && !DASH_LINK_SH
+ prompt "link to /bin/sh"
+ help
+ Create a link symbolic link "/usr/bin/sh" ("/bin/sh") to
+ "bash". Select this to use bash as the interpreter for Bourne
+ shell scripts using the canonical "#!/bin/sh" shebang line.
endif
--
2.43.0
next prev parent reply other threads:[~2024-05-13 13:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-13 12:55 [ptxdist] [PATCH 0/2] Change selection of /usr/bin/sh symlink Ian Abbott
2024-05-13 12:55 ` [ptxdist] [PATCH 1/2] dash: install /usr/bin/sh symlink by default if not provided by BusyBox Ian Abbott
2024-05-31 6:08 ` [ptxdist] [APPLIED] " Michael Olbrich
2024-05-13 12:55 ` Ian Abbott [this message]
2024-05-31 6:08 ` [ptxdist] [APPLIED] bash: allow installation of /usr/bin/sh symlink to be chosen manually Michael Olbrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240513132247.25521-3-abbotti@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox