From mboxrd@z Thu Jan  1 00:00:00 1970
Delivery-date: Sun, 12 May 2024 15:18:17 +0200
Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104])
	by lore.white.stw.pengutronix.de with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <ptxdist-bounces+lore=lore.pengutronix.de@pengutronix.de>)
	id 1s695l-00Aw0p-0T
	for lore@lore.pengutronix.de;
	Sun, 12 May 2024 15:18:17 +0200
Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de)
	by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92)
	(envelope-from <ptxdist-bounces@pengutronix.de>)
	id 1s695f-00052o-Qm; Sun, 12 May 2024 15:18:11 +0200
Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2])
 by metis.whiteo.stw.pengutronix.de with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92)
 (envelope-from <mol@pengutronix.de>)
 id 1s694H-0002hd-1F; Sun, 12 May 2024 15:16:45 +0200
Received: from [2a0a:edc0:0:1101:1d::54] (helo=dude05.red.stw.pengutronix.de)
 by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2)
 (envelope-from <mol@pengutronix.de>)
 id 1s694G-000zYi-LB; Sun, 12 May 2024 15:16:44 +0200
Received: from mol by dude05.red.stw.pengutronix.de with local (Exim 4.96)
 (envelope-from <mol@pengutronix.de>) id 1s694G-00FXWN-1y;
 Sun, 12 May 2024 15:16:44 +0200
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Date: Sun, 12 May 2024 15:16:44 +0200
Message-Id: <20240512131644.3703768-1-m.olbrich@pengutronix.de>
X-Mailer: git-send-email 2.39.2
In-Reply-To: <20240506131244.401909-2-ada@thorsis.com>
References: <20240506131244.401909-2-ada@thorsis.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: Re: [ptxdist] [APPLIED] u-boot: Add option to pass additional make
 env
X-BeenThere: ptxdist@pengutronix.de
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <https://metis.pengutronix.de/mailman/options/ptxdist>,
 <mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <https://metis.pengutronix.de/mailman/private/ptxdist/>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <https://metis.pengutronix.de/mailman/listinfo/ptxdist>,
 <mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Reply-To: ptxdist@pengutronix.de
Cc: Alexander Dahl <ada@thorsis.com>
Sender: "ptxdist" <ptxdist-bounces@pengutronix.de>
X-SA-Exim-Connect-IP: 127.0.0.1
X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de
X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false

Thanks, applied as 32707042153ff15d17e4cf7810f84b1e558e8369.

Michael

[sent from post-receive hook]

On Sun, 12 May 2024 15:16:44 +0200, Alexander Dahl <ada@thorsis.com> wrote:
> Some things need to be set in environment instead of passing them as
> additional make opts.
> 
> Signed-off-by: Alexander Dahl <ada@thorsis.com>
> Message-Id: <20240506131244.401909-2-ada@thorsis.com>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/platforms/u-boot.in b/platforms/u-boot.in
> index 000ca491a1c2..53db146e18ad 100644
> --- a/platforms/u-boot.in
> +++ b/platforms/u-boot.in
> @@ -85,6 +85,15 @@ config U_BOOT_CONFIG
>  
>  endif
>  
> +config U_BOOT_CUSTOM_MAKE_ENV
> +	prompt "Custom (additional) make environment"
> +	string
> +	help
> +	  List of additional env variables set for make at build time.
> +	  Can be used for example to set BINMAN_INDIRS= to a path
> +	  containing firmware files (preferably somewhere in
> +	  sysroot-target).
> +
>  config U_BOOT_CUSTOM_MAKE_OPTS
>  	prompt "Custom make options"
>  	string
> diff --git a/rules/u-boot.make b/rules/u-boot.make
> index 4bc7f3f781fc..e4c963d0c5a3 100644
> --- a/rules/u-boot.make
> +++ b/rules/u-boot.make
> @@ -63,7 +63,9 @@ U_BOOT_CONF_OPT		:= \
>  
>  U_BOOT_MAKE_ENV		:= \
>  	CROSS_COMPILE=$(BOOTLOADER_CROSS_COMPILE) \
> -	HOSTCC=$(HOSTCC)
> +	HOSTCC=$(HOSTCC) \
> +	$(call remove_quotes,$(PTXCONF_U_BOOT_CUSTOM_MAKE_ENV))
> +
>  U_BOOT_MAKE_OPT		:= $(U_BOOT_CONF_OPT)
>  
>  U_BOOT_TAGS_OPT		:= ctags cscope etags