From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Alexander Dahl <ada@thorsis.com>
Subject: Re: [ptxdist] [APPLIED] ptxd_make_world_inject: Remove useless test
Date: Sun, 12 May 2024 15:16:41 +0200 [thread overview]
Message-ID: <20240512131641.3703598-1-m.olbrich@pengutronix.de> (raw)
In-Reply-To: <20240506105051.323546-2-ada@thorsis.com>
Thanks, applied as 33fa14b8b788e2d57d015c91c4c758708824a05d.
Michael
[sent from post-receive hook]
On Sun, 12 May 2024 15:16:41 +0200, Alexander Dahl <ada@thorsis.com> wrote:
> One line above $target is set to "${var}/$(subshell)" and even if $var
> _and_ the result of the subshell call is empty, there's still the slash.
> Thus target is never empty.
>
> Signed-off-by: Alexander Dahl <ada@thorsis.com>
> Acked-by: Michael Riesch <michael.riesch@wolfvision.net>
> Message-Id: <20240506105051.323546-2-ada@thorsis.com>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
>
> diff --git a/scripts/lib/ptxd_make_world_inject.sh b/scripts/lib/ptxd_make_world_inject.sh
> index fe4eb8363619..5c2d0dc5fb3e 100644
> --- a/scripts/lib/ptxd_make_world_inject.sh
> +++ b/scripts/lib/ptxd_make_world_inject.sh
> @@ -11,9 +11,6 @@ ptxd_make_inject() {
>
> source="$(echo ${inject_file} | cut -d ":" -f 1)"
> target="${pkg_source}/$(echo ${inject_file} | cut -d ":" -f 2)"
> - if [ -z "${target}" ]; then
> - target="${source}"
> - fi
>
> if [[ "${source}" =~ ^/.* ]]; then
> ptxd_bailout "'${source}' must not be an absolute path!" \
next prev parent reply other threads:[~2024-05-12 13:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 10:50 [ptxdist] [PATCH v2 0/4] ptxd_make_world_inject: Spring cleanup and optional dest dir Alexander Dahl
2024-05-06 10:50 ` [ptxdist] [PATCH v2 1/4] ptxd_make_world_inject: Remove useless test Alexander Dahl
2024-05-12 13:16 ` Michael Olbrich [this message]
2024-05-06 10:50 ` [ptxdist] [PATCH v2 2/4] ptxd_make_world_inject: Use <PKG>_DIR directly Alexander Dahl
2024-05-12 13:16 ` [ptxdist] [APPLIED] " Michael Olbrich
2024-05-06 10:50 ` [ptxdist] [PATCH v2 3/4] ptxd_make_world_inject: Escape inject path and files Alexander Dahl
2024-05-12 13:16 ` [ptxdist] [APPLIED] " Michael Olbrich
2024-05-06 10:50 ` [ptxdist] [PATCH v2 4/4] ptxd_make_world_inject: Introduce new variable <PKG>_INJECT_OOT Alexander Dahl
2024-05-12 13:16 ` [ptxdist] [APPLIED] " Michael Olbrich
2024-05-06 14:11 ` [ptxdist] [PATCH v2 0/4] ptxd_make_world_inject: Spring cleanup and optional dest dir Michael Riesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240512131641.3703598-1-m.olbrich@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=ada@thorsis.com \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox