From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 03 May 2024 14:29:42 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1s2s2o-00HJYh-0a for lore@lore.pengutronix.de; Fri, 03 May 2024 14:29:42 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1s2s2n-0005lL-JC; Fri, 03 May 2024 14:29:41 +0200 Received: from mail.thorsis.com ([2003:a:e28:26e4::10]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s2s2f-0005kU-0r for ptxdist@pengutronix.de; Fri, 03 May 2024 14:29:34 +0200 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 54DF414833C0; Fri, 3 May 2024 14:29:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thorsis.com; s=dkim; t=1714739372; h=from:subject:date:message-id:to:cc:mime-version:content-type: in-reply-to:references; bh=oNY+4Vze0v0g5Sp1rxQddKhQ+ei0nq5vhV8D1+S6Vp4=; b=fTVKSjGZ3jVDqc8vkJSJsdLVthckFQyjnmg/IzGBquxQljH0Md7kROI4Znp67FgxPfW7tX Eehy6j6iiKyGxYJDDanYFeX/oCSIYhCOgDbhm82H8uf1snmbjSdmKtGYZ/JwGkD6TTyj/R Texo9dzVAJUKDLmnjTape4skSjm7ah61U6m/KmhaEvOrT7kED23QuthZRaqeGsvE4BWJUw cyJAbej4SyIaKD4cEtoKf/sjNBOTcPlmVk+8XbbZEYKBVgw9f52MGmQNAY62UrdInCtqIP vajc+hyZUU8R2Syy0OwPFqyMtpgvXpwwlrsxdsEUKo8w6mUXYIazuVVrf2r2mQ== Date: Fri, 3 May 2024 14:29:31 +0200 From: Alexander Dahl To: Ian Abbott Message-ID: <20240503-spry-maturing-ca0b978407d5@thorsis.com> Mail-Followup-To: Ian Abbott , ptxdist@pengutronix.de References: <20240502145322.141754-1-abbotti@mev.co.uk> <20240503-evade-jumble-3c1c96970cb1@thorsis.com> <20240503-amiss-veteran-105160060dfa@thorsis.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.2.12 (2023-09-09) X-Last-TLS-Session-Version: TLSv1.3 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-2.9 required=4.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Subject: Re: [ptxdist] [PATCH] vim: allow vim to be installed alongside busybox vi and xxd X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false Hello Ian, Am Fri, May 03, 2024 at 01:24:15PM +0100 schrieb Ian Abbott: > On 03/05/2024 10:40, Alexander Dahl wrote: > > Hello Ian, > > > > Am Fri, May 03, 2024 at 10:12:47AM +0100 schrieb Ian Abbott: > > > On 03/05/2024 07:59, Alexander Dahl wrote: > > > > Am Thu, May 02, 2024 at 03:53:22PM +0100 schrieb Ian Abbott: > > > > > + > > > > > +comment "BusyBox' vi is selected!" > > > > > + depends on VIM_VIM && BUSYBOX_VI > > > > > + > > > > > +config VIM_VI_SYMLINK > > > > > + depends on VIM_VIM && !BUSYBOX_VI > > > > > > > > The !BUSYBOX_VI is redundant, but I guess one can keep it. > > > > > > I'm not sure why it's redundant. I don't want this option and BUSYBOX_VI > > > fighting over the symlink to /usr/bin/vi in the image. > > > > Right, there should be only one package setting that symlink. > > > > What I meant was: VIM_VIM already depends on !BUSYBOX_VI so if > > VIM_VI_SYMLINK depends on VIM_VIM, then !BUSYBOX_VI is already > > implicitly satisfied and stating it again is not strictly necessary. > > Actually, my patch removed the dependency of VIM_VIM on !BUSYBOX_VI so that > /usr/bin/vim can be installed alongside busybox's /usr/bin/vi. You're right. I did not look close enough. Sorry for the noise then. > I'm not sure if there is a valid use case for installing both busybox vi and > vim. Obviously it would use more space in the image, but if busybox is > already running, running busybox's vi should be less memory hungry than > running vim. Could confuse users, but otherwise, I think it's fine to make that possible in ptxdist. Developer can decide then. Greets Alex