From: Alexander Dahl <ada@thorsis.com>
To: ptxdist@pengutronix.de
Cc: Michael Riesch <michael.riesch@wolfvision.net>
Subject: [ptxdist] [PATCH 1/4] ptxd_make_world_inject: Remove useless test
Date: Wed, 24 Apr 2024 16:31:06 +0200 [thread overview]
Message-ID: <20240424143109.277373-2-ada@thorsis.com> (raw)
In-Reply-To: <20240424143109.277373-1-ada@thorsis.com>
One line above $target is set to "${var}/$(subshell)" and even if $var
_and_ the result of the subshell call is empty, there's still the slash.
Thus target is never empty.
Signed-off-by: Alexander Dahl <ada@thorsis.com>
---
scripts/lib/ptxd_make_world_inject.sh | 3 ---
1 file changed, 3 deletions(-)
diff --git a/scripts/lib/ptxd_make_world_inject.sh b/scripts/lib/ptxd_make_world_inject.sh
index fe4eb8363..5c2d0dc5f 100644
--- a/scripts/lib/ptxd_make_world_inject.sh
+++ b/scripts/lib/ptxd_make_world_inject.sh
@@ -11,9 +11,6 @@ ptxd_make_inject() {
source="$(echo ${inject_file} | cut -d ":" -f 1)"
target="${pkg_source}/$(echo ${inject_file} | cut -d ":" -f 2)"
- if [ -z "${target}" ]; then
- target="${source}"
- fi
if [[ "${source}" =~ ^/.* ]]; then
ptxd_bailout "'${source}' must not be an absolute path!" \
--
2.39.2
next prev parent reply other threads:[~2024-04-24 14:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 14:31 [ptxdist] [PATCH 0/4] ptxd_make_world_inject: Spring cleanup and optional dest dir Alexander Dahl
2024-04-24 14:31 ` Alexander Dahl [this message]
2024-04-24 14:31 ` [ptxdist] [PATCH 2/4] ptxd_make_world_inject: Use <PKG>_DIR directly Alexander Dahl
2024-04-24 14:31 ` [ptxdist] [PATCH 3/4] ptxd_make_world_inject: Escape inject path and files Alexander Dahl
2024-04-24 14:31 ` [ptxdist] [PATCH 4/4] ptxd_make_world_inject: Introduce separate destination directory Alexander Dahl
2024-05-03 9:48 ` Michael Olbrich
2024-05-03 10:08 ` Alexander Dahl
2024-05-03 15:31 ` Michael Olbrich
2024-05-03 16:05 ` Alexander Dahl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240424143109.277373-2-ada@thorsis.com \
--to=ada@thorsis.com \
--cc=michael.riesch@wolfvision.net \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox