From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 11 Apr 2024 17:05:32 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1ruvzY-007n8X-05 for lore@lore.pengutronix.de; Thu, 11 Apr 2024 17:05:32 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1ruvzX-00053E-Bk; Thu, 11 Apr 2024 17:05:31 +0200 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ruvyz-0004Fz-TI; Thu, 11 Apr 2024 17:04:57 +0200 Received: from [2a0a:edc0:0:1101:1d::54] (helo=dude05.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ruvyz-00BiBy-Gj; Thu, 11 Apr 2024 17:04:57 +0200 Received: from mol by dude05.red.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1ruvyz-005IS3-1V; Thu, 11 Apr 2024 17:04:57 +0200 From: Michael Olbrich To: ptxdist@pengutronix.de Date: Thu, 11 Apr 2024 17:04:57 +0200 Message-Id: <20240411150457.1262560-1-m.olbrich@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240409102429.3143482-1-a.fatoum@pengutronix.de> References: <20240409102429.3143482-1-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [ptxdist] [APPLIED] tf-a: stop defining AS and other variables in cross make env X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: Ahmad Fatoum Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false Thanks, applied as 341428f780542f718348dd9138c50a577f2998cd. Michael [sent from post-receive hook] On Thu, 11 Apr 2024 17:04:57 +0200, Ahmad Fatoum wrote: > The MAKE_ENV incantation results in PTXdist defining variables like AS > and LD that point at the respective tools in the cross toolchain. > > This was unused as TF-A doesn't consult the AS setting in the > environment, and unneeded, because we already supply a CROSS_COMPILE > option, which is used to derive the correct tools. > > This will expectedly change with TF-A v2.11, which should merge commit > cc277de81692 ("build: refactor toolchain detection"), currently sitting > in the integration branch[1]. > > This will start accepting AS to be set from the environment and not only > from the make arguments. This will break using the default cross env as > TF-A assumes AS to point at a C compiler and not at an assembler. > > This will result in build issues, like[2]: > > - hang during tool discovery, because `as -v` keeps waiting for input, > unlike gcc -v > > - Assembler errors during build, because GCC-specific options (e.g. > -DMACRO=VAL) are now passed to as(1). > > Avoid these issues by not defining the CROSS_ENV. > > [1]: https://github.com/ARM-software/arm-trusted-firmware/commit/cc277de8169 > [2]: https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/27163 > > Signed-off-by: Ahmad Fatoum > Message-Id: <20240409102429.3143482-1-a.fatoum@pengutronix.de> > Signed-off-by: Michael Olbrich > > diff --git a/rules/tf-a.make b/rules/tf-a.make > index 54fe7d1e37d8..b8c477476c74 100644 > --- a/rules/tf-a.make > +++ b/rules/tf-a.make > @@ -74,8 +74,6 @@ TF_A_CONF_TOOL := NO > # Compile > # ---------------------------------------------------------------------------- > > -TF_A_MAKE_ENV := $(CROSS_ENV) > - > $(STATEDIR)/tf-a.compile: > @$(call targetinfo) >