From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [ptxdist] [PATCH] tf-a: stop defining AS and other variables in cross make env
Date: Tue, 9 Apr 2024 11:08:16 +0200 [thread overview]
Message-ID: <20240409090816.2343063-1-a.fatoum@pengutronix.de> (raw)
The MAKE_ENV incantation results in PTXdist defining variables like AS
and LD that point at the respective tools in the cross toolchain.
This was unneeded as we already supply the TF-A built with a
CROSS_COMPILE option, which is used to derive the correct tools, but it
didn't hurt.
This will expectedly change with TF-A v2.11, which should merge commit
cc277de81692 ("build: refactor toolchain detection"), currently sitting
in the integration branch.
This changes the default value of AS to be that of the C compiler and
leads to various issues when overriding it with an assembler as was
possible before, e.g.:
- hang during tool discovery, because `as -v` keeps waiting for input,
unlike gcc -v
- Assembler errors during build, because GCC-specific options (e.g.
-DMACRO=VAL) are now passed to as(1).
While TF-A changing the semantics of the AS option is arguably
strange[2], let's take the easy way out and stop setting AS, so the PTXdist
rule can build both old and new TF-A without problems.
[1]: https://github.com/ARM-software/arm-trusted-firmware/commit/cc277de8169
[2]: https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/27163
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
rules/tf-a.make | 2 --
1 file changed, 2 deletions(-)
diff --git a/rules/tf-a.make b/rules/tf-a.make
index 54fe7d1e37d8..b8c477476c74 100644
--- a/rules/tf-a.make
+++ b/rules/tf-a.make
@@ -74,8 +74,6 @@ TF_A_CONF_TOOL := NO
# Compile
# ----------------------------------------------------------------------------
-TF_A_MAKE_ENV := $(CROSS_ENV)
-
$(STATEDIR)/tf-a.compile:
@$(call targetinfo)
--
2.39.2
next reply other threads:[~2024-04-09 9:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-09 9:08 Ahmad Fatoum [this message]
2024-04-09 10:23 ` Christian Melki
2024-04-09 10:37 ` Ahmad Fatoum
2024-04-09 10:39 ` Christian Melki
2024-04-09 10:24 ` Ahmad Fatoum
2024-04-11 15:04 ` [ptxdist] [APPLIED] " Michael Olbrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240409090816.2343063-1-a.fatoum@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox