From: Michiel Schelfhout <michiel.schelfhout@protonic.nl>
To: Michael Olbrich <m.olbrich@pengutronix.de>
Cc: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [APPLIED] python3: Add option to include ensurepip module
Date: Tue, 26 Mar 2024 17:17:10 +0100 [thread overview]
Message-ID: <20240326171710.17308866.michiel.schelfhout@protonic.nl> (raw)
In-Reply-To: <20240326160334.489119-1-m.olbrich@pengutronix.de>
Hi Michael,
I just discovered that this causes a problem with oldconfig. When I run
oldconfig I get the following:
.config:1959:warning: override: reassigning to symbol PYTHON3_PIP
I think this is caused by
https://git.pengutronix.de/cgit/ptxdist/tree/scripts/migrate/migrate_ptx?h=ptxdist-2024.03.0#n428
So this probably means we cannot reuse the symbol PYTHON3_ENSUREPIP?
Regards,
Michiel
On Tue, 26 Mar 2024 17:03:34 +0100
Michael Olbrich <m.olbrich@pengutronix.de> wrote:
> Thanks, applied as 7662f004c174da6cf628793a86655c2dc95f8855.
>
> Michael
>
> [sent from post-receive hook]
>
> On Tue, 26 Mar 2024 17:03:34 +0100, Michiel Schelfhout
> <michiel.schelfhout@protonic.nl> wrote:
> > The configuration option --without-ensurepip disables ensurepip at
> > install time, but the module is still included.
> >
> > Signed-off-by: Michiel Schelfhout <michiel.schelfhout@protonic.nl>
> > Message-Id: <20240325083151.371704-1-michiel.schelfhout@protonic.nl>
> > Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> >
> > diff --git a/rules/python3.in b/rules/python3.in
> > index 70fc44f17b20..afa33b077cbf 100644
> > --- a/rules/python3.in
> > +++ b/rules/python3.in
> > @@ -62,6 +62,10 @@ config PYTHON3_DISTUTILS
> > bool
> > prompt "Include distutils packages"
> >
> > +config PYTHON3_ENSUREPIP
> > + bool
> > + prompt "Include ensurepip module"
> > +
> > endif
> >
> > menu "python3 Extra Modules "
> > diff --git a/rules/python3.make b/rules/python3.make
> > index 99a553c008d7..ae128c12a4f3 100644
> > --- a/rules/python3.make
> > +++ b/rules/python3.make
> > @@ -166,6 +166,7 @@ PYTHON3_SKIP-$(call ptx/opt-dis,
> > PTXCONF_PYTHON3_READLINE) += */readline*so
> > PYTHON3_SKIP-$(call ptx/opt-dis, PTXCONF_PYTHON3_SQLITE) +=
> > */sqlite3 */_sqlite3*.so PYTHON3_SKIP-$(call ptx/opt-dis,
> > PTXCONF_PYTHON3_SSL) += */ssl.pyc */_ssl*.so
> > */hashlib.pyc */_hashlib*.so PYTHON3_SKIP-$(call ptx/opt-dis,
> > PTXCONF_PYTHON3_DISTUTILS) += */distutils
> > +PYTHON3_SKIP-$(call ptx/opt-dis, PTXCONF_PYTHON3_ENSUREPIP)
> > += */ensurepip $(STATEDIR)/python3.targetinstall: @$(call
> > targetinfo)
next prev parent reply other threads:[~2024-03-26 16:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 8:31 [ptxdist] [PATCH v2] " Michiel Schelfhout
2024-03-26 16:03 ` [ptxdist] [APPLIED] " Michael Olbrich
2024-03-26 16:17 ` Michiel Schelfhout [this message]
2024-03-26 18:53 ` Michael Olbrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240326171710.17308866.michiel.schelfhout@protonic.nl \
--to=michiel.schelfhout@protonic.nl \
--cc=m.olbrich@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox