From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Sat, 23 Mar 2024 10:00:20 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rnxEi-000yfq-1a for lore@lore.pengutronix.de; Sat, 23 Mar 2024 10:00:20 +0100 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1rnxEi-000508-0r; Sat, 23 Mar 2024 10:00:20 +0100 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rnxE2-0003xu-13; Sat, 23 Mar 2024 09:59:38 +0100 Received: from [2a0a:edc0:0:1101:1d::54] (helo=dude05.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rnxE1-0080Jc-Ko; Sat, 23 Mar 2024 09:59:37 +0100 Received: from mol by dude05.red.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rnxE1-00ASmA-1x; Sat, 23 Mar 2024 09:59:37 +0100 From: Michael Olbrich To: ptxdist@pengutronix.de Date: Sat, 23 Mar 2024 09:59:37 +0100 Message-Id: <20240323085937.2493887-1-m.olbrich@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240321114423.1503313-1-lapeddk@gmail.com> References: <20240321114423.1503313-1-lapeddk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [ptxdist] [APPLIED] libqmi: Add option to enable QMI firmware update tool X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: Lars Pedersen Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false Thanks, applied as 61143543fa1d18cfc6ec7340777bf64b5b54dc75. Michael [sent from post-receive hook] On Sat, 23 Mar 2024 09:59:37 +0100, Lars Pedersen wrote: > Signed-off-by: Lars Pedersen > Message-Id: <20240321114423.1503313-1-lapeddk@gmail.com> > Signed-off-by: Michael Olbrich > > diff --git a/rules/libqmi.in b/rules/libqmi.in > index 571bfa3a0aa6..1b4c8c88c146 100644 > --- a/rules/libqmi.in > +++ b/rules/libqmi.in > @@ -15,4 +15,7 @@ config LIBQMI_MBIM_QMUX > bool "enable mbim-qmux support" > default y if MODEMMANAGER > > +config LIBQMI_FIRMWARE_UPDATE > + bool "Add firmware update tool for QMI devices" > + > endif > diff --git a/rules/libqmi.make b/rules/libqmi.make > index 03487369cbdf..2cc6695cb061 100644 > --- a/rules/libqmi.make > +++ b/rules/libqmi.make > @@ -36,7 +36,7 @@ LIBQMI_LICENSE_FILES := \ > LIBQMI_CONF_TOOL := meson > LIBQMI_CONF_OPT := \ > $(CROSS_MESON_USR) \ > - -Dfirmware_update=false \ > + -Dfirmware_update=$(call ptx/truefalse, PTXCONF_LIBQMI_FIRMWARE_UPDATE) \ > -Dcollection=full \ > -Dmbim_qmux=$(call ptx/truefalse, PTXCONF_LIBQMI_MBIM_QMUX) \ > -Dmm_runtime_check=false \ > @@ -65,6 +65,10 @@ $(STATEDIR)/libqmi.targetinstall: > @$(call install_copy, libqmi, 0, 0, 0755, -, /usr/bin/qmicli) > @$(call install_copy, libqmi, 0, 0, 0755, -, /usr/bin/qmi-network) > > +ifdef PTXCONF_LIBQMI_FIRMWARE_UPDATE > + @$(call install_copy, libqmi, 0, 0, 0755, -, /usr/bin/qmi-firmware-update) > +endif > + > @$(call install_copy, libqmi, 0, 0, 0755, -, /usr/libexec/qmi-proxy) > @$(call install_lib, libqmi, 0, 0, 0644, libqmi-glib) >