From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Alexander Dahl <ada@thorsis.com>
Subject: Re: [ptxdist] [APPLIED] image-rauc: Fix quotation marks / whitespace handling
Date: Thu, 8 Feb 2024 17:03:36 +0100 [thread overview]
Message-ID: <20240208160336.3248994-1-m.olbrich@pengutronix.de> (raw)
In-Reply-To: <20240202151209.2535721-6-ada@thorsis.com>
Thanks, applied as f216869a760d69d54ebbe4a0ebd08265f54be3ca.
Michael
[sent from post-receive hook]
On Thu, 08 Feb 2024 17:03:36 +0100, Alexander Dahl <ada@thorsis.com> wrote:
> If you had set
> PTXCONF_IMAGE_RAUC_DESCRIPTION="${PTXCONF_PROJECT_VENDOR} ${PTXCONF_PROJECT}"
> like DistroKit-2023.12.0 does, target update.raucb failed with
> 'command not found' because of wrong quoting and interpreting parts of
> PTXCONF_IMAGE_RAUC_DESCRIPTION as command.
>
> Signed-off-by: Alexander Dahl <ada@thorsis.com>
> Message-Id: <20240202151209.2535721-6-ada@thorsis.com>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
>
> diff --git a/rules/image-rauc.make b/rules/image-rauc.make
> index e267e78c68f2..def2ade1e237 100644
> --- a/rules/image-rauc.make
> +++ b/rules/image-rauc.make
> @@ -56,7 +56,7 @@ IMAGE_RAUC_ENV = \
> RAUC_BUNDLE_FORMAT=$(IMAGE_RAUC_BUNDLE_FORMAT) \
> RAUC_BUNDLE_VERSION="$(call remove_quotes, $(PTXCONF_RAUC_BUNDLE_VERSION))" \
> RAUC_BUNDLE_BUILD=$(call ptx/sh, date +%FT%T%z) \
> - RAUC_BUNDLE_DESCRIPTION=$(PTXCONF_IMAGE_RAUC_DESCRIPTION) \
> + RAUC_BUNDLE_DESCRIPTION="$(call remove_quotes, $(PTXCONF_IMAGE_RAUC_DESCRIPTION))" \
> $(IMAGE_RAUC_ENV_HOOK) \
> RAUC_KEY="$(shell cs_get_uri update)" \
> RAUC_CERT="$(shell cs_get_uri update)" \
prev parent reply other threads:[~2024-02-08 16:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-02 15:12 [ptxdist] [PATCH 0/5] FIT images with U-Boot and barebox on recent DistroKit Alexander Dahl
2024-02-02 15:12 ` [ptxdist] [PATCH 1/5] kernel-fit: Review help text Alexander Dahl
2024-02-08 16:03 ` [ptxdist] [APPLIED] " Michael Olbrich
2024-02-02 15:12 ` [ptxdist] [PATCH 2/5] kernel-fit: Allow using 'kernel_noload' as sub-image type Alexander Dahl
2024-02-08 16:03 ` [ptxdist] [APPLIED] " Michael Olbrich
2024-02-02 15:12 ` [ptxdist] [PATCH 3/5] blspec-entry: Fix kernel entry for FIT image Alexander Dahl
2024-02-08 16:03 ` [ptxdist] [APPLIED] " Michael Olbrich
2024-02-02 15:12 ` [ptxdist] [PATCH 4/5] u-boot: Avoid hooking oldconfig if kconfig is not selected Alexander Dahl
2024-02-08 16:03 ` [ptxdist] [APPLIED] " Michael Olbrich
2024-02-02 15:12 ` [ptxdist] [PATCH 5/5] image-rauc: Fix quotation marks / whitespace handling Alexander Dahl
2024-02-06 11:41 ` Roland Hieber
2024-02-08 16:03 ` Michael Olbrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240208160336.3248994-1-m.olbrich@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=ada@thorsis.com \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox