From mboxrd@z Thu Jan  1 00:00:00 1970
Delivery-date: Thu, 08 Feb 2024 17:09:27 +0100
Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104])
	by lore.white.stw.pengutronix.de with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <ptxdist-bounces+lore=lore.pengutronix.de@pengutronix.de>)
	id 1rY6xq-008tOz-0G
	for lore@lore.pengutronix.de;
	Thu, 08 Feb 2024 17:09:27 +0100
Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de)
	by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92)
	(envelope-from <ptxdist-bounces@pengutronix.de>)
	id 1rY6xr-0008E0-56; Thu, 08 Feb 2024 17:09:27 +0100
Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2])
 by metis.whiteo.stw.pengutronix.de with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92)
 (envelope-from <mol@pengutronix.de>)
 id 1rY6sD-0002OZ-2z; Thu, 08 Feb 2024 17:03:37 +0100
Received: from [2a0a:edc0:0:1101:1d::54] (helo=dude05.red.stw.pengutronix.de)
 by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2)
 (envelope-from <mol@pengutronix.de>)
 id 1rY6sC-005FGB-0F; Thu, 08 Feb 2024 17:03:36 +0100
Received: from mol by dude05.red.stw.pengutronix.de with local (Exim 4.96)
 (envelope-from <mol@pengutronix.de>) id 1rY6sB-00DdBt-37;
 Thu, 08 Feb 2024 17:03:35 +0100
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Date: Thu,  8 Feb 2024 17:03:35 +0100
Message-Id: <20240208160335.3248904-1-m.olbrich@pengutronix.de>
X-Mailer: git-send-email 2.39.2
In-Reply-To: <20240202151209.2535721-5-ada@thorsis.com>
References: <20240202151209.2535721-5-ada@thorsis.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: Re: [ptxdist] [APPLIED] u-boot: Avoid hooking oldconfig if kconfig
 is not selected
X-BeenThere: ptxdist@pengutronix.de
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <https://metis.pengutronix.de/mailman/options/ptxdist>,
 <mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <https://metis.pengutronix.de/mailman/private/ptxdist/>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <https://metis.pengutronix.de/mailman/listinfo/ptxdist>,
 <mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Reply-To: ptxdist@pengutronix.de
Cc: Alexander Dahl <ada@thorsis.com>
Sender: "ptxdist" <ptxdist-bounces@pengutronix.de>
X-SA-Exim-Connect-IP: 127.0.0.1
X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de
X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false

Thanks, applied as 611215d2df98c1fd3a0a78557320088b8b85ba95.

Michael

[sent from post-receive hook]

On Thu, 08 Feb 2024 17:03:35 +0100, Alexander Dahl <ada@thorsis.com> wrote:
> Calling `ptxdist oldconfig u-boot` (or `ptxdist oldconfig all`) makes
> only sense if the package actually uses Kconfig.  If it does not, you
> probably got an at best annoying error message of a missing u-boot
> .config in your BSP.
> 
> Fixes: 44e565de9b2d ("u-boot: Add option to use Kconfig based configuration")
> Signed-off-by: Alexander Dahl <ada@thorsis.com>
> Message-Id: <20240202151209.2535721-5-ada@thorsis.com>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/rules/u-boot.make b/rules/u-boot.make
> index cadca4a6bc92..4bc7f3f781fc 100644
> --- a/rules/u-boot.make
> +++ b/rules/u-boot.make
> @@ -214,7 +214,9 @@ $(STATEDIR)/u-boot.clean:
>  # oldconfig / menuconfig
>  # ----------------------------------------------------------------------------
>  
> +ifdef PTXCONF_U_BOOT_CONFIGSYSTEM_KCONFIG
>  u-boot_oldconfig u-boot_menuconfig u-boot_nconfig: $(STATEDIR)/u-boot.extract
>  	@$(call world/kconfig, U_BOOT, $(subst u-boot_,,$@))
> +endif
>  
>  # vim: syntax=make