From mboxrd@z Thu Jan  1 00:00:00 1970
Delivery-date: Thu, 08 Feb 2024 17:06:33 +0100
Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104])
	by lore.white.stw.pengutronix.de with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <ptxdist-bounces+lore=lore.pengutronix.de@pengutronix.de>)
	id 1rY6v2-008t7o-0W
	for lore@lore.pengutronix.de;
	Thu, 08 Feb 2024 17:06:33 +0100
Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de)
	by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92)
	(envelope-from <ptxdist-bounces@pengutronix.de>)
	id 1rY6v2-0005dV-SY; Thu, 08 Feb 2024 17:06:32 +0100
Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2])
 by metis.whiteo.stw.pengutronix.de with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92)
 (envelope-from <mol@pengutronix.de>)
 id 1rY6ry-0001S7-DF; Thu, 08 Feb 2024 17:03:22 +0100
Received: from [2a0a:edc0:0:1101:1d::54] (helo=dude05.red.stw.pengutronix.de)
 by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2)
 (envelope-from <mol@pengutronix.de>)
 id 1rY6rx-005FFA-VY; Thu, 08 Feb 2024 17:03:21 +0100
Received: from mol by dude05.red.stw.pengutronix.de with local (Exim 4.96)
 (envelope-from <mol@pengutronix.de>) id 1rY6rx-00Dcz6-31;
 Thu, 08 Feb 2024 17:03:21 +0100
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Date: Thu,  8 Feb 2024 17:03:21 +0100
Message-Id: <20240208160321.3248113-1-m.olbrich@pengutronix.de>
X-Mailer: git-send-email 2.39.2
In-Reply-To: <20240130105815.3091486-2-m.tretter@pengutronix.de>
References: <20240130105815.3091486-2-m.tretter@pengutronix.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: Re: [ptxdist] [APPLIED] pipewire: fix readline support
X-BeenThere: ptxdist@pengutronix.de
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <https://metis.pengutronix.de/mailman/options/ptxdist>,
 <mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <https://metis.pengutronix.de/mailman/private/ptxdist/>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <https://metis.pengutronix.de/mailman/listinfo/ptxdist>,
 <mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Reply-To: ptxdist@pengutronix.de
Cc: Michael Tretter <m.tretter@pengutronix.de>
Sender: "ptxdist" <ptxdist-bounces@pengutronix.de>
X-SA-Exim-Connect-IP: 127.0.0.1
X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de
X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false

Thanks, applied as dd2d8a07716ca498ae9e0b69a0625c28d7be8655.

Michael

[sent from post-receive hook]

On Thu, 08 Feb 2024 17:03:21 +0100, Michael Tretter <m.tretter@pengutronix.de> wrote:
> Due to the missing PTXCONF_ prefix, pw-ctl was always built without
> readline support even though the rule looked like readline support was
> enabled. Furthermore, the readline dependency was pulled in.
> 
> Add the PTXCONF_ prefix to actually enable readline support.
> 
> Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
> Message-Id: <20240130105815.3091486-2-m.tretter@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/rules/pipewire.make b/rules/pipewire.make
> index 34081c5ceeb5..8747ebe6cecc 100644
> --- a/rules/pipewire.make
> +++ b/rules/pipewire.make
> @@ -90,7 +90,7 @@ PIPEWIRE_CONF_OPT	:= \
>  	-Dpw-cat=enabled \
>  	-Dpw-cat-ffmpeg=disabled \
>  	-Draop=$(call ptx/endis,PTXCONF_PIPEWIRE_RAOP)d \
> -	-Dreadline=$(call ptx/endis,PIPEWIRE_PW_CTL)d \
> +	-Dreadline=$(call ptx/endis,PTXCONF_PIPEWIRE_PW_CTL)d \
>  	-Drlimits-install=false \
>  	-Drlimits-match=@pipewire \
>  	-Drlimits-memlock=4194304 \