From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Michael Tretter <m.tretter@pengutronix.de>
Subject: Re: [ptxdist] [APPLIED] pipewire: fix readline support
Date: Thu, 8 Feb 2024 17:03:21 +0100 [thread overview]
Message-ID: <20240208160321.3248113-1-m.olbrich@pengutronix.de> (raw)
In-Reply-To: <20240130105815.3091486-2-m.tretter@pengutronix.de>
Thanks, applied as dd2d8a07716ca498ae9e0b69a0625c28d7be8655.
Michael
[sent from post-receive hook]
On Thu, 08 Feb 2024 17:03:21 +0100, Michael Tretter <m.tretter@pengutronix.de> wrote:
> Due to the missing PTXCONF_ prefix, pw-ctl was always built without
> readline support even though the rule looked like readline support was
> enabled. Furthermore, the readline dependency was pulled in.
>
> Add the PTXCONF_ prefix to actually enable readline support.
>
> Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
> Message-Id: <20240130105815.3091486-2-m.tretter@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
>
> diff --git a/rules/pipewire.make b/rules/pipewire.make
> index 34081c5ceeb5..8747ebe6cecc 100644
> --- a/rules/pipewire.make
> +++ b/rules/pipewire.make
> @@ -90,7 +90,7 @@ PIPEWIRE_CONF_OPT := \
> -Dpw-cat=enabled \
> -Dpw-cat-ffmpeg=disabled \
> -Draop=$(call ptx/endis,PTXCONF_PIPEWIRE_RAOP)d \
> - -Dreadline=$(call ptx/endis,PIPEWIRE_PW_CTL)d \
> + -Dreadline=$(call ptx/endis,PTXCONF_PIPEWIRE_PW_CTL)d \
> -Drlimits-install=false \
> -Drlimits-match=@pipewire \
> -Drlimits-memlock=4194304 \
next prev parent reply other threads:[~2024-02-08 16:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 10:58 [ptxdist] [PATCH 1/2] readline: fix pkg-config errors with NCURSES_WIDE_CHAR Michael Tretter
2024-01-30 10:58 ` [ptxdist] [PATCH 2/2] pipewire: fix readline support Michael Tretter
2024-02-08 16:03 ` Michael Olbrich [this message]
2024-02-08 16:03 ` [ptxdist] [APPLIED] readline: fix pkg-config errors with NCURSES_WIDE_CHAR Michael Olbrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240208160321.3248113-1-m.olbrich@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=m.tretter@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox