mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Tretter <m.tretter@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: pza@pengutronix.de, mtr@pengutronix.de
Subject: [ptxdist] [PATCH 1/2] readline: fix pkg-config errors with NCURSES_WIDE_CHAR
Date: Tue, 30 Jan 2024 11:58:14 +0100	[thread overview]
Message-ID: <20240130105815.3091486-1-m.tretter@pengutronix.de> (raw)

readline.pc contains Requires.private=ncurses, even if readline is built
with ncursesw. When a user of readline uses pkg-config to ask for the
cflags, the lookup fails if ncursesw without compatibility with ncurses
is used.

Fix it by ensuring that ncurses compatibility is enabled if readline is
built with ncurses.

Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
---
 rules/readline.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/rules/readline.in b/rules/readline.in
index 036860409a56..7673ce7497eb 100644
--- a/rules/readline.in
+++ b/rules/readline.in
@@ -2,6 +2,7 @@
 menuconfig READLINE
 	tristate
 	select NCURSES if READLINE_NCURSES
+	select NCURSES_BACKWARD_COMPATIBLE_NON_WIDE_CHAR if READLINE_NCURSES && NCURSES_WIDE_CHAR
 	select TERMCAP if READLINE_TERMCAP
 	select GCCLIBS_GCC_S
 	prompt "readline                      "
-- 
2.39.2




             reply	other threads:[~2024-01-30 10:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-30 10:58 Michael Tretter [this message]
2024-01-30 10:58 ` [ptxdist] [PATCH 2/2] pipewire: fix readline support Michael Tretter
2024-02-08 16:03   ` [ptxdist] [APPLIED] " Michael Olbrich
2024-02-08 16:03 ` [ptxdist] [APPLIED] readline: fix pkg-config errors with NCURSES_WIDE_CHAR Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240130105815.3091486-1-m.tretter@pengutronix.de \
    --to=m.tretter@pengutronix.de \
    --cc=mtr@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    --cc=pza@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox