mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
* [ptxdist] [PATCH 1/2] igt-gpu-tools: limit blacklisting of BINDNOW to x86
@ 2023-12-04 14:49 Michael Tretter
  2023-12-04 14:49 ` [ptxdist] [PATCH 2/2] igt-gpu-tools: avoid installing all files in targetinstall Michael Tretter
  2023-12-07 11:10 ` [ptxdist] [APPLIED] igt-gpu-tools: limit blacklisting of BINDNOW to x86 Michael Olbrich
  0 siblings, 2 replies; 4+ messages in thread
From: Michael Tretter @ 2023-12-04 14:49 UTC (permalink / raw)
  To: ptxdist; +Cc: mtr

The segfaults caused by BINDNOW are x86-specific.

Limit the blacklisting to x86 systems and add further documentation, why
BINDNOW has to be blacklisted.

Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
---
 rules/igt-gpu-tools.make | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/rules/igt-gpu-tools.make b/rules/igt-gpu-tools.make
index a2d9f4d5a221..734db1d07e8c 100644
--- a/rules/igt-gpu-tools.make
+++ b/rules/igt-gpu-tools.make
@@ -29,10 +29,16 @@ IGT_GPU_TOOLS_LICENSE_FILES := \
 # Prepare
 # ----------------------------------------------------------------------------
 
-# For some reason, intel_gpu_frequency and other segfault immediately if
-# built with -Wl,-z,now.
+# On x86 systems, libigt resolves igt_half_to_float and igt_float_to_half as
+# indirect functions at runtime by checking CPU features with igt_x86_features.
+# The igt_x86_features function is implemented is a different object and the
+# call uses the PLT itself. If lazy binding is disabled, this causes a segfault
+# while resolving the symbols for libigt on x64 systems. Disable BINDNOW on X86
+# systems to prevent the segfaults.
+ifdef PTXCONF_ARCH_X86
 IGT_GPU_TOOLS_WRAPPER_BLACKLIST := \
 	TARGET_HARDEN_BINDNOW
+endif
 
 IGT_GPU_TOOLS_LIBDRM-y					:=
 ifdef PTXCONF_ARCH_X86
-- 
2.39.2




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-12-07 11:11 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-04 14:49 [ptxdist] [PATCH 1/2] igt-gpu-tools: limit blacklisting of BINDNOW to x86 Michael Tretter
2023-12-04 14:49 ` [ptxdist] [PATCH 2/2] igt-gpu-tools: avoid installing all files in targetinstall Michael Tretter
2023-12-07 11:10   ` [ptxdist] [APPLIED] " Michael Olbrich
2023-12-07 11:10 ` [ptxdist] [APPLIED] igt-gpu-tools: limit blacklisting of BINDNOW to x86 Michael Olbrich

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox