From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 07 Dec 2023 12:11:22 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rBCHp-006uLv-2I for lore@lore.pengutronix.de; Thu, 07 Dec 2023 12:11:22 +0100 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1rBCHq-00053r-3G; Thu, 07 Dec 2023 12:11:22 +0100 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rBCGZ-0002wT-Cx; Thu, 07 Dec 2023 12:10:03 +0100 Received: from [2a0a:edc0:0:1101:1d::54] (helo=dude05.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rBCGZ-00EAWU-0S; Thu, 07 Dec 2023 12:10:03 +0100 Received: from mol by dude05.red.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rBCGY-005ZnU-38; Thu, 07 Dec 2023 12:10:02 +0100 From: Michael Olbrich To: ptxdist@pengutronix.de Date: Thu, 7 Dec 2023 12:10:02 +0100 Message-Id: <20231207111002.1329237-1-m.olbrich@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231204144934.426001-2-m.tretter@pengutronix.de> References: <20231204144934.426001-2-m.tretter@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [ptxdist] [APPLIED] igt-gpu-tools: avoid installing all files in targetinstall X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: Michael Tretter Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false Thanks, applied as 6e88952a025cf75e8a3238e93bcf12605b3b6ef1. Michael [sent from post-receive hook] On Thu, 07 Dec 2023 12:10:02 +0100, Michael Tretter wrote: > The igt-gpu-tools installed all files by using install_tree during > targetinstall. That resulted in the installation in a lot of > platform-dependent tools and tests to be installed. > > Avoid this by explicitly installing the tools and tests depending on the > package configuration. > > As code_cov_parse_info is a Perl script, add Perl as a runtime > dependency if the tests are enabled. > > Signed-off-by: Michael Tretter > Message-Id: <20231204144934.426001-2-m.tretter@pengutronix.de> > Signed-off-by: Michael Olbrich > > diff --git a/rules/igt-gpu-tools.in b/rules/igt-gpu-tools.in > index 10849c296cdb..24ba18c23621 100644 > --- a/rules/igt-gpu-tools.in > +++ b/rules/igt-gpu-tools.in > @@ -17,6 +17,7 @@ menuconfig IGT_GPU_TOOLS > select UDEV_LIBUDEV > select ZLIB > select JSON_C if IGT_GPU_TOOLS_TEST_RUNNER > + select PERL if IGT_GPU_TOOLS_TESTS && RUNTIME > prompt "igt-gpu-tools " > help > igt-gpu-tools is a package of tools for debugging the Intel > @@ -38,6 +39,10 @@ config IGT_GPU_TOOLS_NOUVEAU > bool > default LIBDRM_NOUVEAU > > +config IGT_GPU_TOOLS_FREEDRENO > + bool > + default LIBDRM_FREEDRENO > + > config IGT_GPU_TOOLS_TESTS > bool > prompt "build and install tests" > diff --git a/rules/igt-gpu-tools.make b/rules/igt-gpu-tools.make > index 734db1d07e8c..891ea5486cb7 100644 > --- a/rules/igt-gpu-tools.make > +++ b/rules/igt-gpu-tools.make > @@ -86,10 +86,79 @@ $(STATEDIR)/igt-gpu-tools.targetinstall: > @$(call install_fixup, igt-gpu-tools,AUTHOR,"Michael Olbrich ") > @$(call install_fixup, igt-gpu-tools,DESCRIPTION,missing) > > - @$(call install_tree, igt-gpu-tools, 0, 0, -, /usr/lib) > - @$(call install_tree, igt-gpu-tools, 0, 0, -, /usr/bin) > - @$(call install_tree, igt-gpu-tools, 0, 0, -, /usr/share/igt-gpu-tools) > + @$(call install_lib, igt-gpu-tools, 0, 0, 0644, libigt) > + > + @$(call install_copy, igt-gpu-tools, 0, 0, 0755, -, /usr/bin/amd_hdmi_compliance) > + @$(call install_copy, igt-gpu-tools, 0, 0, 0755, -, /usr/bin/dpcd_reg) > + @$(call install_copy, igt-gpu-tools, 0, 0, 0755, -, /usr/bin/gputop) > + @$(call install_copy, igt-gpu-tools, 0, 0, 0755, -, /usr/bin/lsgpu) > + > +ifdef PTXCONF_IGT_GPU_TOOLS_INTEL > + @$(call install_lib, igt-gpu-tools, 0, 0, 0644, libi915_perf) > + > + @$(call install_copy, igt-gpu-tools, 0, 0, 0755, -, /usr/bin/i915-perf-configs) > + @$(call install_copy, igt-gpu-tools, 0, 0, 0755, -, /usr/bin/i915-perf-control) > + @$(call install_copy, igt-gpu-tools, 0, 0, 0755, -, /usr/bin/i915-perf-reader) > + @$(call install_copy, igt-gpu-tools, 0, 0, 0755, -, /usr/bin/i915-perf-recorder) > + @$(call install_copy, igt-gpu-tools, 0, 0, 0755, -, /usr/bin/intel_audio_dump) > + @$(call install_copy, igt-gpu-tools, 0, 0, 0755, -, /usr/bin/intel_backlight) > + @$(call install_copy, igt-gpu-tools, 0, 0, 0755, -, /usr/bin/intel_bios_dumper) > + @$(call install_copy, igt-gpu-tools, 0, 0, 0755, -, /usr/bin/intel_display_crc) > + @$(call install_copy, igt-gpu-tools, 0, 0, 0755, -, /usr/bin/intel_display_poller) > + @$(call install_copy, igt-gpu-tools, 0, 0, 0755, -, /usr/bin/intel_dp_compliance) > + @$(call install_copy, igt-gpu-tools, 0, 0, 0755, -, /usr/bin/intel_dump_decode) > + @$(call install_copy, igt-gpu-tools, 0, 0, 0755, -, /usr/bin/intel_error_decode) > + @$(call install_copy, igt-gpu-tools, 0, 0, 0755, -, /usr/bin/intel_firmware_decode) > + @$(call install_copy, igt-gpu-tools, 0, 0, 0755, -, /usr/bin/intel_forcewaked) > + @$(call install_copy, igt-gpu-tools, 0, 0, 0755, -, /usr/bin/intel_framebuffer_dump) > + @$(call install_copy, igt-gpu-tools, 0, 0, 0755, -, /usr/bin/intel_gem_info) > + @$(call install_copy, igt-gpu-tools, 0, 0, 0755, -, /usr/bin/intel-gfx-fw-info) > + @$(call install_copy, igt-gpu-tools, 0, 0, 0755, -, /usr/bin/intel_gpu_abrt) > + @$(call install_copy, igt-gpu-tools, 0, 0, 0755, -, /usr/bin/intel_gpu_frequency) > + @$(call install_copy, igt-gpu-tools, 0, 0, 0755, -, /usr/bin/intel_gpu_time) > + @$(call install_copy, igt-gpu-tools, 0, 0, 0755, -, /usr/bin/intel_gpu_top) > + @$(call install_copy, igt-gpu-tools, 0, 0, 0755, -, /usr/bin/intel_gtt) > + @$(call install_copy, igt-gpu-tools, 0, 0, 0755, -, /usr/bin/intel_guc_logger) > + @$(call install_copy, igt-gpu-tools, 0, 0, 0755, -, /usr/bin/intel_gvtg_test) > + @$(call install_copy, igt-gpu-tools, 0, 0, 0755, -, /usr/bin/intel_infoframes) > + @$(call install_copy, igt-gpu-tools, 0, 0, 0755, -, /usr/bin/intel_l3_parity) > + @$(call install_copy, igt-gpu-tools, 0, 0, 0755, -, /usr/bin/intel_lid) > + @$(call install_copy, igt-gpu-tools, 0, 0, 0755, -, /usr/bin/intel_opregion_decode) > + @$(call install_copy, igt-gpu-tools, 0, 0, 0755, -, /usr/bin/intel_panel_fitter) > + @$(call install_copy, igt-gpu-tools, 0, 0, 0755, -, /usr/bin/intel_perf_counters) > + @$(call install_copy, igt-gpu-tools, 0, 0, 0755, -, /usr/bin/intel_pm_rpm) > + @$(call install_copy, igt-gpu-tools, 0, 0, 0755, -, /usr/bin/intel_reg) > + @$(call install_copy, igt-gpu-tools, 0, 0, 0755, -, /usr/bin/intel_reg_checker) > + @$(call install_copy, igt-gpu-tools, 0, 0, 0755, -, /usr/bin/intel_residency) > + @$(call install_copy, igt-gpu-tools, 0, 0, 0755, -, /usr/bin/intel_stepping) > + @$(call install_copy, igt-gpu-tools, 0, 0, 0755, -, /usr/bin/intel_vbt_decode) > + @$(call install_copy, igt-gpu-tools, 0, 0, 0755, -, /usr/bin/intel_watermark) > + @$(call install_copy, igt-gpu-tools, 0, 0, 0755, -, /usr/bin/xe_reg) > + > + @$(call install_tree, igt-gpu-tools, 0, 0, -, /usr/share/igt-gpu-tools/registers) > +endif > + > +ifdef PTXCONF_IGT_GPU_TOOLS_FREEDRENO > + @$(call install_copy, igt-gpu-tools, 0, 0, 0755, -, /usr/bin/msm_dp_compliance) > +endif > + > +ifdef PTXCONF_IGT_GPU_TOOLS_TESTS > + $(call install_copy, igt-gpu-tools, 0, 0, 0755, -, /usr/bin/code_cov_capture) > + $(call install_copy, igt-gpu-tools, 0, 0, 0755, -, /usr/bin/code_cov_gather_on_build) > + $(call install_copy, igt-gpu-tools, 0, 0, 0755, -, /usr/bin/code_cov_gather_on_test) > + $(call install_copy, igt-gpu-tools, 0, 0, 0755, -, /usr/bin/code_cov_gen_report) > + $(call install_copy, igt-gpu-tools, 0, 0, 0755, -, /usr/bin/code_cov_parse_info) > + > @$(call install_tree, igt-gpu-tools, 0, 0, -, /usr/libexec/igt-gpu-tools) > + @$(call install_glob, igt-gpu-tools, 0, 0, -, /usr/share/igt-gpu-tools, *.png,) > +endif > + > +ifdef PTXCONF_IGT_GPU_TOOLS_TEST_RUNNER > + $(call install_copy, igt-gpu-tools, 0, 0, 0755, -, /usr/bin/igt_comms_decoder) > + $(call install_copy, igt-gpu-tools, 0, 0, 0755, -, /usr/bin/igt_results) > + $(call install_copy, igt-gpu-tools, 0, 0, 0755, -, /usr/bin/igt_resume) > + $(call install_copy, igt-gpu-tools, 0, 0, 0755, -, /usr/bin/igt_runner) > +endif > > @$(call install_finish, igt-gpu-tools) >