From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 07 Dec 2023 12:11:06 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rBCHZ-006uKu-3B for lore@lore.pengutronix.de; Thu, 07 Dec 2023 12:11:06 +0100 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1rBCHa-0004tL-Cb; Thu, 07 Dec 2023 12:11:06 +0100 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rBCGY-0002w4-K4; Thu, 07 Dec 2023 12:10:02 +0100 Received: from [2a0a:edc0:0:1101:1d::54] (helo=dude05.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rBCGY-00EAWQ-7N; Thu, 07 Dec 2023 12:10:02 +0100 Received: from mol by dude05.red.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rBCGY-005Zmo-0Z; Thu, 07 Dec 2023 12:10:02 +0100 From: Michael Olbrich To: ptxdist@pengutronix.de Date: Thu, 7 Dec 2023 12:10:02 +0100 Message-Id: <20231207111002.1329195-1-m.olbrich@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231204144934.426001-1-m.tretter@pengutronix.de> References: <20231204144934.426001-1-m.tretter@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [ptxdist] [APPLIED] igt-gpu-tools: limit blacklisting of BINDNOW to x86 X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: Michael Tretter Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false Thanks, applied as 9d271fb8bf569a1909f5bfcd7ac2c6877141376a. Michael [sent from post-receive hook] On Thu, 07 Dec 2023 12:10:02 +0100, Michael Tretter wrote: > The segfaults caused by BINDNOW are x86-specific. > > Limit the blacklisting to x86 systems and add further documentation, why > BINDNOW has to be blacklisted. > > Signed-off-by: Michael Tretter > Message-Id: <20231204144934.426001-1-m.tretter@pengutronix.de> > Signed-off-by: Michael Olbrich > > diff --git a/rules/igt-gpu-tools.make b/rules/igt-gpu-tools.make > index a2d9f4d5a221..734db1d07e8c 100644 > --- a/rules/igt-gpu-tools.make > +++ b/rules/igt-gpu-tools.make > @@ -29,10 +29,16 @@ IGT_GPU_TOOLS_LICENSE_FILES := \ > # Prepare > # ---------------------------------------------------------------------------- > > -# For some reason, intel_gpu_frequency and other segfault immediately if > -# built with -Wl,-z,now. > +# On x86 systems, libigt resolves igt_half_to_float and igt_float_to_half as > +# indirect functions at runtime by checking CPU features with igt_x86_features. > +# The igt_x86_features function is implemented is a different object and the > +# call uses the PLT itself. If lazy binding is disabled, this causes a segfault > +# while resolving the symbols for libigt on x64 systems. Disable BINDNOW on X86 > +# systems to prevent the segfaults. > +ifdef PTXCONF_ARCH_X86 > IGT_GPU_TOOLS_WRAPPER_BLACKLIST := \ > TARGET_HARDEN_BINDNOW > +endif > > IGT_GPU_TOOLS_LIBDRM-y := > ifdef PTXCONF_ARCH_X86