mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Tretter <m.tretter@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: mtr@pengutronix.de
Subject: [ptxdist] [PATCH 1/2] igt-gpu-tools: limit blacklisting of BINDNOW to x86
Date: Mon,  4 Dec 2023 15:49:33 +0100	[thread overview]
Message-ID: <20231204144934.426001-1-m.tretter@pengutronix.de> (raw)

The segfaults caused by BINDNOW are x86-specific.

Limit the blacklisting to x86 systems and add further documentation, why
BINDNOW has to be blacklisted.

Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
---
 rules/igt-gpu-tools.make | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/rules/igt-gpu-tools.make b/rules/igt-gpu-tools.make
index a2d9f4d5a221..734db1d07e8c 100644
--- a/rules/igt-gpu-tools.make
+++ b/rules/igt-gpu-tools.make
@@ -29,10 +29,16 @@ IGT_GPU_TOOLS_LICENSE_FILES := \
 # Prepare
 # ----------------------------------------------------------------------------
 
-# For some reason, intel_gpu_frequency and other segfault immediately if
-# built with -Wl,-z,now.
+# On x86 systems, libigt resolves igt_half_to_float and igt_float_to_half as
+# indirect functions at runtime by checking CPU features with igt_x86_features.
+# The igt_x86_features function is implemented is a different object and the
+# call uses the PLT itself. If lazy binding is disabled, this causes a segfault
+# while resolving the symbols for libigt on x64 systems. Disable BINDNOW on X86
+# systems to prevent the segfaults.
+ifdef PTXCONF_ARCH_X86
 IGT_GPU_TOOLS_WRAPPER_BLACKLIST := \
 	TARGET_HARDEN_BINDNOW
+endif
 
 IGT_GPU_TOOLS_LIBDRM-y					:=
 ifdef PTXCONF_ARCH_X86
-- 
2.39.2




             reply	other threads:[~2023-12-04 14:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-04 14:49 Michael Tretter [this message]
2023-12-04 14:49 ` [ptxdist] [PATCH 2/2] igt-gpu-tools: avoid installing all files in targetinstall Michael Tretter
2023-12-07 11:10   ` [ptxdist] [APPLIED] " Michael Olbrich
2023-12-07 11:10 ` [ptxdist] [APPLIED] igt-gpu-tools: limit blacklisting of BINDNOW to x86 Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231204144934.426001-1-m.tretter@pengutronix.de \
    --to=m.tretter@pengutronix.de \
    --cc=mtr@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox