From mboxrd@z Thu Jan  1 00:00:00 1970
Delivery-date: Fri, 24 Nov 2023 08:28:30 +0100
Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104])
	by lore.white.stw.pengutronix.de with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <ptxdist-bounces+lore=lore.pengutronix.de@pengutronix.de>)
	id 1r6Qc1-0077Og-2u
	for lore@lore.pengutronix.de;
	Fri, 24 Nov 2023 08:28:30 +0100
Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de)
	by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92)
	(envelope-from <ptxdist-bounces@pengutronix.de>)
	id 1r6Qc2-0006bj-9C; Fri, 24 Nov 2023 08:28:30 +0100
Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2])
 by metis.whiteo.stw.pengutronix.de with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92)
 (envelope-from <mol@pengutronix.de>)
 id 1r6Qbh-0006b7-5T; Fri, 24 Nov 2023 08:28:09 +0100
Received: from [2a0a:edc0:0:1101:1d::54] (helo=dude05.red.stw.pengutronix.de)
 by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2)
 (envelope-from <mol@pengutronix.de>)
 id 1r6Qbg-00BDQx-PG; Fri, 24 Nov 2023 08:28:08 +0100
Received: from mol by dude05.red.stw.pengutronix.de with local (Exim 4.96)
 (envelope-from <mol@pengutronix.de>) id 1r6Qbg-007ywp-23;
 Fri, 24 Nov 2023 08:28:08 +0100
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Date: Fri, 24 Nov 2023 08:28:08 +0100
Message-Id: <20231124072808.1902482-1-m.olbrich@pengutronix.de>
X-Mailer: git-send-email 2.39.2
In-Reply-To: <20231110093705.45879-2-u.kleine-koenig@pengutronix.de>
References: <20231110093705.45879-2-u.kleine-koenig@pengutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [ptxdist] [APPLIED] ptxd_make_nested: Fix parameter passing for
 --dirty, --force and --pedantic
X-BeenThere: ptxdist@pengutronix.de
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <https://metis.pengutronix.de/mailman/options/ptxdist>,
 <mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <https://metis.pengutronix.de/mailman/private/ptxdist/>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <https://metis.pengutronix.de/mailman/listinfo/ptxdist>,
 <mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Reply-To: ptxdist@pengutronix.de
Cc: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
Sender: "ptxdist" <ptxdist-bounces@pengutronix.de>
X-SA-Exim-Connect-IP: 127.0.0.1
X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de
X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false

Thanks, applied as 98bc55e65d3b5c64ea15c86d2ac6627fdb13fbae.

Michael

[sent from post-receive hook]

On Fri, 24 Nov 2023 08:28:08 +0100, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
> Some variables corresponding to ptxdist parameters use "true" as value
> when given, others use "1". PTXDIST_DIRTY, PTXDIST_FORCE and
> PTXDIST_PEDANTIC are in the first group according to
> 
> 	git grep -E 'PTXDIST_(DIRTY|FORCE|FEDANTIC)='
> 
> . Adapt ptxd_make_nested_ptxdist() accordingly.
> 
> Fixes: 5169ae99daf8 ("add support for nested PTXdist execution")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Message-Id: <20231110093705.45879-2-u.kleine-koenig@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/scripts/lib/ptxd_make_nested.sh b/scripts/lib/ptxd_make_nested.sh
> index cae12bceb377..2c4af5337207 100644
> --- a/scripts/lib/ptxd_make_nested.sh
> +++ b/scripts/lib/ptxd_make_nested.sh
> @@ -46,13 +46,13 @@ ptxd_make_nested_ptxdist() {
>      fi
>      args=( "cd" "${pkg_workspace}" "&&" "${PTXDIST_TOPDIR}/bin/ptxdist" )
>  
> -    if [ "${PTXDIST_DIRTY}" = 1 ]; then
> +    if [ "${PTXDIST_DIRTY}" = true ]; then
>  	args[${#args[*]}]="--dirty"
>      fi
> -    if [ "${PTXDIST_FORCE}" = 1 ]; then
> +    if [ "${PTXDIST_FORCE}" = true ]; then
>  	args[${#args[*]}]="--force"
>      fi
> -    if [ "${PTXDIST_PEDANTIC}" = 1 ]; then
> +    if [ "${PTXDIST_PEDANTIC}" = true ]; then
>  	args[${#args[*]}]="--pedantic"
>      fi
>      if [ "${PTXDIST_QUIET}" = 1 ]; then