From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [ptxdist] [APPLIED] ptxd_make_nested: Fix parameter passing for --dirty, --force and --pedantic
Date: Fri, 24 Nov 2023 08:28:08 +0100 [thread overview]
Message-ID: <20231124072808.1902482-1-m.olbrich@pengutronix.de> (raw)
In-Reply-To: <20231110093705.45879-2-u.kleine-koenig@pengutronix.de>
Thanks, applied as 98bc55e65d3b5c64ea15c86d2ac6627fdb13fbae.
Michael
[sent from post-receive hook]
On Fri, 24 Nov 2023 08:28:08 +0100, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
> Some variables corresponding to ptxdist parameters use "true" as value
> when given, others use "1". PTXDIST_DIRTY, PTXDIST_FORCE and
> PTXDIST_PEDANTIC are in the first group according to
>
> git grep -E 'PTXDIST_(DIRTY|FORCE|FEDANTIC)='
>
> . Adapt ptxd_make_nested_ptxdist() accordingly.
>
> Fixes: 5169ae99daf8 ("add support for nested PTXdist execution")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Message-Id: <20231110093705.45879-2-u.kleine-koenig@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
>
> diff --git a/scripts/lib/ptxd_make_nested.sh b/scripts/lib/ptxd_make_nested.sh
> index cae12bceb377..2c4af5337207 100644
> --- a/scripts/lib/ptxd_make_nested.sh
> +++ b/scripts/lib/ptxd_make_nested.sh
> @@ -46,13 +46,13 @@ ptxd_make_nested_ptxdist() {
> fi
> args=( "cd" "${pkg_workspace}" "&&" "${PTXDIST_TOPDIR}/bin/ptxdist" )
>
> - if [ "${PTXDIST_DIRTY}" = 1 ]; then
> + if [ "${PTXDIST_DIRTY}" = true ]; then
> args[${#args[*]}]="--dirty"
> fi
> - if [ "${PTXDIST_FORCE}" = 1 ]; then
> + if [ "${PTXDIST_FORCE}" = true ]; then
> args[${#args[*]}]="--force"
> fi
> - if [ "${PTXDIST_PEDANTIC}" = 1 ]; then
> + if [ "${PTXDIST_PEDANTIC}" = true ]; then
> args[${#args[*]}]="--pedantic"
> fi
> if [ "${PTXDIST_QUIET}" = 1 ]; then
prev parent reply other threads:[~2023-11-24 7:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-10 9:37 [ptxdist] [PATCH] " Uwe Kleine-König
2023-11-24 7:28 ` Michael Olbrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231124072808.1902482-1-m.olbrich@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=ptxdist@pengutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox