From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 19 Oct 2023 11:18:10 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qtPAQ-00E3DO-JV for lore@lore.pengutronix.de; Thu, 19 Oct 2023 11:18:10 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1qtPAP-0002bR-RG; Thu, 19 Oct 2023 11:18:09 +0200 Received: from mail.thorsis.com ([92.198.35.195]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qtPAB-0002b0-O8 for ptxdist@pengutronix.de; Thu, 19 Oct 2023 11:17:56 +0200 Date: Thu, 19 Oct 2023 11:16:49 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thorsis.com; s=default; t=1697707071; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Mlgw4EiT4IYW3JUf14F7kR8269jqQNDkJRyMZr9rBcg=; b=cqfOGdi9lmr9KHYzuAPIhgO8Biy/B1lAONjth0ZvfhQ7nzLLaUS9NAGdJlCJLbOcRNakk5 Qvx17p90YAHwTde6Ex2Ic6naXDjcwLC/3rYEKb6QtUmE0RfiVZbYc6g7KNjai9SlYclnwU tYKvFd6DnOwZWf2j8wnD16MYwTVeyioE/4+irrSSfMBsyKzuFxexzSkm/UJGyl5Yy58ClS DAIH4+gJB7pf2lzSfmRSD8jQOfVAzD3t73xtTwQ0IMvwNqMjj2Y9rsyrGLELQQRk2sJQUU SSJs5a9KM//bIZoziyCIkAu4yXQjNLbpIv6hTP9a/E8tLoj1LHyCXLrTc1WDng== From: Alexander Dahl To: Andreas Helmcke , ptxdist@pengutronix.de Message-ID: <20231019-unvalued-outtakes-1ee75b22f0b8@ifak-system.com> Mail-Followup-To: Andreas Helmcke , ptxdist@pengutronix.de References: <20231018160014.197898-1-ahelmcke@ela-soft.com> <20231019-clumsily-praying-d840b025f2a6@ifak-system.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231019-clumsily-praying-d840b025f2a6@ifak-system.com> X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-2.8 required=4.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Subject: Re: [ptxdist] [PATCH v3] lighttpd: Version bump, 1.4.67 -> 1.4.72 X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false Hello, got it sorted out, although the experience in #lighttpd IRC channel was not as friendly as I hoped for. See below. Am Thu, Oct 19, 2023 at 10:33:47AM +0200 schrieb Alexander Dahl: > Hello Andreas, > > sorry to bother you again. :-/ > > I just tested v3 of your patch on my target. See below. > > Am Wed, Oct 18, 2023 at 06:00:14PM +0200 schrieb Andreas Helmcke: > > Bugfixes and several changes. e.g. > > - Stronger TLS defaults > > - HTTP/2 Support now as optional module > > - Some former modules are now build in > > > > Link: https://www.lighttpd.net/2023/1/3/1.4.68/ > > Link: https://www.lighttpd.net/2023/2/10/1.4.69/ > > Link: https://www.lighttpd.net/2023/5/10/1.4.70/ > > Link: https://www.lighttpd.net/2023/5/27/1.4.71/ > > Link: https://www.lighttpd.net/2023/10/6/1.4.72/ > > Signed-off-by: Andreas Helmcke > > --- > > rules/lighttpd.in | 35 +++++++++++------------------------ > > rules/lighttpd.make | 15 +++++---------- > > 2 files changed, 16 insertions(+), 34 deletions(-) > > > > diff --git a/rules/lighttpd.in b/rules/lighttpd.in > > index 910271087..670a00d15 100644 > > --- a/rules/lighttpd.in > > +++ b/rules/lighttpd.in > > @@ -69,13 +69,6 @@ endmenu > > > > menu "modules " > > > > -config LIGHTTPD_MOD_ACCESS > > - bool > > - prompt "mod_access" > > - default y > > - help > > - Deny access to some files. > > - > > config LIGHTTPD_MOD_ACCESSLOG > > bool > > prompt "mod_accesslog" > > @@ -83,12 +76,6 @@ config LIGHTTPD_MOD_ACCESSLOG > > help > > flexible logging of requests served > > > > -config LIGHTTPD_MOD_ALIAS > > - bool > > - prompt "mod_alias" > > - help > > - Specify a special document-root for a given url-subset. > > - > > config LIGHTTPD_MOD_AUTH > > bool > > prompt "mod_auth" > > @@ -123,11 +110,12 @@ config LIGHTTPD_BZ2LIB > > Enable bzip2 support for mod_deflate. > > endif > > > > -config LIGHTTPD_MOD_FASTCGI > > +config LIGHTTPD_MOD_DIRLISTING > > bool > > - prompt "mod_fastcgi" > > - > > -if LIGHTTPD_MOD_FASTCGI > > + prompt "mod_dirlisting" > > + default y > > + help > > + Creates an HTML page listing the contents of the target directory. > > > > config LIGHTTPD_MOD_FASTCGI_PHP > > bool > > @@ -140,7 +128,12 @@ config LIGHTTPD_MOD_FASTCGI_PHP > > comment "PHP CGI SAPI must be enabled" > > depends on !PHP8_SAPI_CGI > > > > -endif > > +config LIGHTTPD_MOD_H2 > > + bool > > + prompt "mod_h2" > > + default y > > + help > > + HTTP/2 support > > I fear we can not make this an option (yet). If you do not load 'mod_h2', you need an additional setting in lighttpd.conf to make lighttpd happy. Maybe we could add that in the help text? Or in the commit message? It is this one: server.feature-flags += ( "server.h2proto" => "disable" ) > > > > > config LIGHTTPD_MOD_MAGNET > > bool > > @@ -149,12 +142,6 @@ config LIGHTTPD_MOD_MAGNET > > help > > A module to control the request handling > > > > -config LIGHTTPD_MOD_REWRITE > > - bool > > - prompt "mod_rewrite" > > - help > > - Module for URL rewriting > > - > > config LIGHTTPD_MOD_WEBDAV > > bool > > prompt "mod_webdav" > > diff --git a/rules/lighttpd.make b/rules/lighttpd.make > > index 3aa54a1fb..a7e4b05c1 100644 > > --- a/rules/lighttpd.make > > +++ b/rules/lighttpd.make > > @@ -15,8 +15,8 @@ PACKAGES-$(PTXCONF_LIGHTTPD) += lighttpd > > # > > # Paths and names > > # > > -LIGHTTPD_VERSION := 1.4.67 > > -LIGHTTPD_MD5 := 64822c5061001673162cf9775d91a80b > > +LIGHTTPD_VERSION := 1.4.72 > > +LIGHTTPD_MD5 := 466f9fe131cd7d38d0fe47d2e6a2939d > > LIGHTTPD := lighttpd-$(LIGHTTPD_VERSION) > > LIGHTTPD_SUFFIX := tar.xz > > LIGHTTPD_URL := http://download.lighttpd.net/lighttpd/releases-1.4.x/$(LIGHTTPD).$(LIGHTTPD_SUFFIX) > > @@ -93,24 +93,19 @@ $(STATEDIR)/lighttpd.install: > > # ---------------------------------------------------------------------------- > > > > LIGHTTPD_MODULES-y := > > -LIGHTTPD_MODULES-$(PTXCONF_LIGHTTPD_MOD_ACCESS) += mod_access > > LIGHTTPD_MODULES-$(PTXCONF_LIGHTTPD_MOD_ACCESSLOG) += mod_accesslog > > -LIGHTTPD_MODULES-$(PTXCONF_LIGHTTPD_MOD_ALIAS) += mod_alias > > LIGHTTPD_MODULES-$(PTXCONF_LIGHTTPD_MOD_AUTH) += mod_auth > > LIGHTTPD_MODULES-$(PTXCONF_LIGHTTPD_MOD_AUTH) += mod_authn_file > > LIGHTTPD_MODULES-$(PTXCONF_LIGHTTPD_MOD_DEFLATE) += mod_deflate > > -LIGHTTPD_MODULES-$(PTXCONF_LIGHTTPD_MOD_FASTCGI) += mod_fastcgi > > +LIGHTTPD_MODULES-$(PTXCONF_LIGHTTPD_MOD_DIRLISTING) += mod_dirlisting > > +LIGHTTPD_MODULES-$(PTXCONF_LIGHTTPD_MOD_H2) += mod_h2 > > We probably need to always install mod_h2. I turned the option off > and now I get this at runtime > (`lighttpd -tt -f /etc/lighttpd/lighttpd.conf`): > > 2012-01-01 00:46:15: (plugin.c.209) dlopen() failed for: /usr/lib/lighttpd/mod_h2.so /usr/lib/lighttpd/mod_h2.so: cannot open shared object file: No such file or directory You get this message if you don't have "mod_h2" in server.modules in lighttpd.conf. You need to set the line from above. There's a default configuration file 'projectroot/etc/lighttpd/lighttpd.conf' in ptxdist. Maybe with some magic like this: server.feature-flags += ( "server.h2proto" => "@H2ENDIS@" ) And then replacing the placeholder with either 'enable' or 'disable'? If someone else is struggling like me to find that option in lighttpd documentation, here it is: https://redmine.lighttpd.net/projects/lighttpd/wiki/Server_feature-flagsDetails > I asked the lighttpd devs on IRC about this, but got no helpful > response yet. > > Apart of that my previous configuration does not work anymore, I get > some "unknown config-key" messages in log and the webserver only > returns 403. Have to look deeper into that, but I just wanted to get > out that mod_h2 information first. The other problems came from modules I used which where added to @MODULES@ before but are not anymore. The lighttpd.conf however still requires to load them. After adding another 'server.modules += …' with that modules in my config, everything works as before now, so … Tested-by: Alexander Dahl Greets Alex > > Greets > Alex > > > LIGHTTPD_MODULES-$(PTXCONF_LIGHTTPD_MOD_MAGNET) += mod_magnet > > LIGHTTPD_MODULES-$(PTXCONF_LIGHTTPD_OPENSSL) += mod_openssl > > -LIGHTTPD_MODULES-$(PTXCONF_LIGHTTPD_MOD_REWRITE) += mod_rewrite > > LIGHTTPD_MODULES-$(PTXCONF_LIGHTTPD_MOD_WEBDAV) += mod_webdav > > LIGHTTPD_MODULES-y += $(call remove_quotes,$(PTXCONF_LIGHTTPD_MOD_EXTRA)) > > > > LIGHTTPD_MODULE_STRING := $(subst $(space),$(comma),$(addsuffix \",$(addprefix \",$(LIGHTTPD_MODULES-y)))) > > > > -# add modules that are always loaded > > -LIGHTTPD_MODULES_INSTALL := mod_indexfile mod_dirlisting mod_staticfile $(LIGHTTPD_MODULES-y) > > - > > $(STATEDIR)/lighttpd.targetinstall: > > @$(call targetinfo) > > > > @@ -127,7 +122,7 @@ $(STATEDIR)/lighttpd.targetinstall: > > /usr/sbin/lighttpd-angel) > > > > ifdef PTXCONF_LIGHTTPD_INSTALL_SELECTED_MODULES > > - @$(foreach mod,$(LIGHTTPD_MODULES_INSTALL), \ > > + @$(foreach mod,$(LIGHTTPD_MODULES-y), \ > > $(call install_lib, lighttpd, 0, 0, 0644, lighttpd/$(mod))$(ptx/nl)) > > else > > # # modules > > -- > > 2.39.2 > > > > >