From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Wed, 18 Oct 2023 13:40:09 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qt4uH-00CvyA-Kq for lore@lore.pengutronix.de; Wed, 18 Oct 2023 13:40:09 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1qt4uG-0002yG-Lb; Wed, 18 Oct 2023 13:40:08 +0200 Received: from mail.thorsis.com ([92.198.35.195]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qt4tz-0002xO-K8 for ptxdist@pengutronix.de; Wed, 18 Oct 2023 13:39:52 +0200 Date: Wed, 18 Oct 2023 13:38:44 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thorsis.com; s=default; t=1697629189; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UQDxVnuLCxFg9GjCm85kl/KfNtzte5b1NcKLHVc9IyI=; b=G5wNtKHVYVqmqr8rhyNcIdXU0IlNuf+M3u8wJS9bwW4tGOYJfniggb3EDBcr3ZLq7tKK+C ZpiCirLD0FyTNyfpfaq9yjjf+9TLEkwK9wsQjSdGuiKluVJf9VF846jfLV+aMHmyOVaH1K z5cytkyIFlavzHIZnpXisSPx2zCAOh9oDGJOPQsOCUPG6opiITE7gItk5VhWJp2ax3uPlf K59isS32M/WGPn2GbIW54/WaDBRhYjfI0NOTAsJnbEMYvTFBS8c2NC5//AqBSaal1T5oNb iC4H/Pq6WbkyTBmPoU/NgkOnoGm0wTa4q6BWXINPmbLrogt1PLsI1bWG+nQM4A== From: Alexander Dahl To: Andreas Helmcke Message-ID: <20231018-depose-trillion-6d774c70ffca@ifak-system.com> Mail-Followup-To: Andreas Helmcke , ptxdist@pengutronix.de References: <20231016170734.263595-1-ahelmcke@ela-soft.com> <20231017-tackiness-overdrive-065957c90abd@ifak-system.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-2.8 required=4.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Subject: Re: [ptxdist] [PATCH] lighttpd: Version bump, 1.4.67 -> 1.4.72 X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false Hello Andreas, Am Wed, Oct 18, 2023 at 12:53:58PM +0200 schrieb Andreas Helmcke: > Hello Alexander, hello Michael, > > Am 18.10.23 um 07:54 schrieb Michael Olbrich: > > On Tue, Oct 17, 2023 at 08:05:11AM +0200, Alexander Dahl wrote: > >> Hello Andreas, > >> > >> first of all, thanks for taking care of this, my remarks below. > >> > >> Am Mon, Oct 16, 2023 at 07:07:34PM +0200 schrieb Andreas Helmcke: > >>> Bugfixes and several changes. e.g. > >>> - Stronger TLS defaults > >>> - HTTP/2 Support now as optional module > >>> > >>> see: https://www.lighttpd.net/releases/ > >> > >> Link: https://www.lighttpd.net/2023/1/3/1.4.68/ > >> Link: https://www.lighttpd.net/2023/2/10/1.4.69/ > >> Link: https://www.lighttpd.net/2023/5/10/1.4.70/ > >> Link: https://www.lighttpd.net/2023/5/27/1.4.71/ > >> Link: https://www.lighttpd.net/2023/10/6/1.4.72/ > > thanks, changed that > > >>> Signed-off-by: Andreas Helmcke > >>> --- > >>> rules/lighttpd.make | 4 ++-- > >>> 1 file changed, 2 insertions(+), 2 deletions(-) > >>> > >>> diff --git a/rules/lighttpd.make b/rules/lighttpd.make > >>> index 3aa54a1fb..7b7abf7d2 100644 > >>> --- a/rules/lighttpd.make > >>> +++ b/rules/lighttpd.make > >>> @@ -15,8 +15,8 @@ PACKAGES-$(PTXCONF_LIGHTTPD) += lighttpd > >>> # > >>> # Paths and names > >>> # > >>> -LIGHTTPD_VERSION := 1.4.67 > >>> -LIGHTTPD_MD5 := 64822c5061001673162cf9775d91a80b > >>> +LIGHTTPD_VERSION := 1.4.72 > >>> +LIGHTTPD_MD5 := 466f9fe131cd7d38d0fe47d2e6a2939d > >> > >> Builds fine, but … > >> > >> That 1.4.70 in particular needs a little more work on the ptxdist > >> package, because several modules are not built separate anymore, but > >> built-in now. This makes some of the LIGHTTPD_MOD_* options in menu > >> not necessary anymore, and breaks targetinstall if those should have > >> been installed before, e.g. like this: > >> > >> Error: ptxd_lib_install: cannot find library 'lighttpd/mod_indexfile'! > > I can not (re)produce your error, but ... Interesting. It's one of the modules always installed. Maybe we have different options set? Comes from these lines: 111 # add modules that are always loaded 112 LIGHTTPD_MODULES_INSTALL := mod_indexfile mod_dirlisting mod_staticfile $(LIGHTTPD_MODULES-y) Please test with PTXCONF_LIGHTTPD_INSTALL_SELECTED_MODULES set and not set, and compare. I guess you will also find 'mod_staticfile'? > >> The list of affected modules is in the 1.4.70 announcement. > > i have cleaned up the list of modules and removed the now obsolete ones. > > >> With 1.4.71 HTTP/2 support is moved to a separate module however and > >> no longer built-in anymore. Should we introduce a new menu option for > >> that or let the ptxdist user configure it with > >> PTXCONF_LIGHTTPD_MOD_EXTRA instead? > > > > If it requires additional dependencies then a new option is mandatory. > > If not, then I don't really care either way. Just leave it as is I guess. > > > > I have decided to create a new menu option because i do think, that > this is a central/fundamental part and not some exotic stuff so it > deserves one. Thanks. It's good if you can turn it off. Might save some space for folks who don't want HTTP/2 for whatever reason. Greets Alex > > > >>> LIGHTTPD := lighttpd-$(LIGHTTPD_VERSION) > >>> LIGHTTPD_SUFFIX := tar.xz > >>> LIGHTTPD_URL := http://download.lighttpd.net/lighttpd/releases-1.4.x/$(LIGHTTPD).$(LIGHTTPD_SUFFIX) > >>> -- > >>> 2.39.2 > >>> > > Andreas >